[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40f361ace3e9: [clangd] Include Cleaner: ignore headers with IWYU export pragmas (authored by kbobyrev). Repository: rG LLVM Github Monorepo

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429637. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files:

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great! A few more nits Comment at: clang-tools-extra/clangd/Headers.cpp:151 + // will know that the next inclusion is behind the IWYU pragma. + if

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429619. kbobyrev added a comment. Also rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files: clang-tools-extra/clangd/Headers.cpp

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429618. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address review comments: the structure is a bit different but the bug is now actually removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:134 + return false; +return inMainFile() ? handleCommentInMainFile(PP, Range) +: handleCommentInHeaderFile(PP, Range); the split seems to be

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 428949. kbobyrev added a comment. Remove redundant comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files: clang-tools-extra/clangd/Headers.cpp

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 428947. kbobyrev added a comment. Remove unwanted formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files: clang-tools-extra/clangd/Headers.cpp

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev created this revision. kbobyrev added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: