[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

nathanchance added a comment. @amyk Thank you a lot for the fix! I'll pull it down and verify everything is fixed tonight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125506/new/ https://reviews.llvm.org/D125506

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk added a comment. In D125506#3528380 , @nathanchance wrote: > I bisected a crash when compiling the Linux kernel to this change. > > A reduced C reproducer: > > enum { > OP_CB_GETATTR = 3, > OP_CB_RECALL, > OP_CB_RECALL_ANY = 8, > O

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk added a comment. In D125506#3528380 , @nathanchance wrote: > I bisected a crash when compiling the Linux kernel to this change. > > A reduced C reproducer: > > enum { > OP_CB_GETATTR = 3, > OP_CB_RECALL, > OP_CB_RECALL_ANY = 8, > O

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

nathanchance added subscribers: nickdesaulniers, nathanchance. nathanchance added a comment. I bisected a crash when compiling the Linux kernel to this change. A reduced C reproducer: enum { OP_CB_GETATTR = 3, OP_CB_RECALL, OP_CB_RECALL_ANY = 8, OP_CB_RECALL_SLOT = 10, OP_C

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc35ca3a1c78f: [PowerPC] Implement XL compat __fnabs and __fnabss builtins. (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk updated this revision to Diff 430671. amyk added a comment. - Add a P6 +VSX run line and remove extra P7 /P8 lines for backend test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-fnabs.ll:46 +; RUN: -mattr=-vsx < %s | FileCheck %s --check-prefix=CHECK-NOVSX + +declare double @llvm.ppc.fnabs(double) lei wrote: > nit: same as before no need to test all

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

lei added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-fnabs.ll:46 +; RUN: -mattr=-vsx < %s | FileCheck %s --check-prefix=CHECK-NOVSX + +declare double @llvm.ppc.fnabs(double) nit: same as before no need to test all combination f

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk updated this revision to Diff 430249. amyk added a comment. Address review comments: - Remove `-no-opaque-pointers` and updates CHECKs - Simplify runs and checks of C and IR test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125506/new/

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

lei accepted this revision. lei added a comment. This revision is now accepted and ready to land. LGTM with minor updates before commit. Comment at: clang/test/CodeGen/PowerPC/builtins-ppc-xlcompat-fnabs.c:25 +// RUN: %clang_cc1 -no-opaque-pointers -triple powerpc-unknown-aix \

[PATCH] D125506: [PowerPC] Implement XL compat __fnabs and __fnabss builtins.

amyk created this revision. amyk added reviewers: PowerPC, power-llvm-team, nemanjai, lei. amyk added a project: LLVM. Herald added subscribers: shchenz, hiraditya. Herald added a project: All. amyk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-com