[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

aaron.ballman added a comment. I know it's retroactive, but this also LGTM. Thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commi

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added a comment. pushed 45e01ce5fe6a5e4dc25ffdf626caa344fbcb93dd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45e01ce5fe6a: [clang] Avoid suggesting typoed directives in `.S` files (authored by ken-matsui, committed by nickdesaulniers). Repository: rG LLVM

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added a comment. sorted, will commit soon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added a comment. Sorry, it looks like `arcanist` or my PHP runtime was auto updated on my host and has regressed. I need to sort that out first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D12

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added a comment. > I do not have permission to land this patch, so could you please do it on my > behalf? Will do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added a comment. @nickdesaulniers Thank you for your review! I do not have permission to land this patch, so could you please do it on my behalf? Here is my information: Name: `Ken Matsui` Email: `v...@kmatsui.me` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added a comment. Sorry for having missed it. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui updated this revision to Diff 429877. ken-matsui added a comment. Remove `- < %s` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Preprocess

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.S:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s - < %s + These three can be removed now as well. Clang will read `%s` as input without the need to read from std

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added a comment. Removed it 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui updated this revision to Diff 429872. ken-matsui added a comment. Remove `-x assembler-with-cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 Files: clang/lib/Lex/PPDirectives.cpp clang/

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.S:1 +// RUN: %clang_cc1 -fsyntax-only -verify -S %s -o %t + nickdesaulniers wrote: > nickdesaulniers wrote: > > Consider adding a test: > > > > ``` > > // RUN: %c

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:484 const SourceLocation &EndLoc) const { + // If this is a `.S` file, treat unknown # directives as non-preprocessor + // directives. nickde

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added a comment. Thank you for your review! I've fixed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui updated this revision to Diff 429869. ken-matsui added a comment. Update the code as reviewed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 Files: clang/lib/Lex/PPDirectives.cpp clang/tes