This revision was automatically updated to reflect the committed changes.
Closed by commit rG8f70d16c9ab2: [clang-format] Handle attributes in enum
declaration. (authored by tchatow, committed by curdeius).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
tchatow added a comment.
No, I'll need someone to commit it on my behalf.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125848/new/
https://reviews.llvm.org/D125848
___
cfe-commits mailing list
cfe-commi
curdeius accepted this revision.
curdeius added a comment.
LGTM. Thanks a lot!
Do you have commit rights or need some help landing this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125848/new/
https://reviews.llvm.org/D125848
___
tchatow updated this revision to Diff 431489.
tchatow added a comment.
Added tests for non-empty enums
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125848/new/
https://reviews.llvm.org/D125848
Files:
clang/lib/Format/UnwrappedLineParser.cpp
c
curdeius added a comment.
Could you please add test cases with non-empty enums both with and without
comments please like in the bug report?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125848/new/
https://reviews.llvm.org/D125848
__
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.
This looks good to me, but let the others chime in..
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125848/new/
https://reviews.l
tchatow created this revision.
Herald added a project: All.
tchatow requested review of this revision.
Herald added a project: clang.
Fixes https://github.com/llvm/llvm-project/issues/55457
Ensures that attributes in the enum declaration are interpreted
correctly, for instance:
enum class [[nodi
