[PATCH] D126192: [Driver] Support linking with lld for target AVR

MaskRay added a comment. I am still uncomfortable with such a change. Trying to be smart sometimes may get in the way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 ___ cfe-commits mailing list cf

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432468. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/lib/a

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:528 + CmdArgs.push_back(Args.MakeArgString("-T")); + CmdArgs.push_back(Args.MakeArgString(Prefix + *FamilyName + ".x")); +} Though I can seperate my AVR pro

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432460. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/lib/a

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:461 << CPU; - } else if (TC.getGCCInstallPath().empty()) { -// We can not link since there is no avr-ld. benshi001 wrote: > This check is no longer needed,

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432459. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/lib/avr/lib/ldscripts/avr5.xn clang/test/Driver/avr-tool

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 marked 2 inline comments as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:435 - std::string Linker = getToolChain().GetProgramPath(getShortName()); + // Compute the linker program path, and use GNU "avr-ld" as default. + con

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432457. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld clang/test/Driver/Inputs/basic_avr_tree/usr/l

[PATCH] D126192: [Driver] Support linking with lld for target AVR

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:530 + if (AVRLibcRoot && FamilyName) { +std::string Prefix(*AVRLibcRoot + "/lib/ldscripts/"); +if (llvm::sys::fs::is_directory(Prefix)) { I am concerned with the m

[PATCH] D126192: [Driver] Support linking with lld for target AVR

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:435 - std::string Linker = getToolChain().GetProgramPath(getShortName()); + // Compute the linker program path, and use GNU "avr-ld" as default. + const Arg* A = Args.getLastArg(options::OPT_fuse_

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:441 +if (!llvm::sys::fs::can_execute(FullPath)) + D.Diag(diag::err_drv_invalid_linker_name) << Linker; +else We report an error if the linker specified via `-fuse-ld` is

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 431565. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld clang/test/Driver/Inputs/basic_avr_tree/usr/l

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:461 << CPU; - } else if (TC.getGCCInstallPath().empty()) { -// We can not link since there is no avr-ld. This check is no longer needed, since we will check

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 431332. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld clang/test/Driver/Inputs/basic_avr_tree/usr/l

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay. Herald added subscribers: StephenFan, Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repositor