[PATCH] D126707: [analyzer][NFC] Move overconstrained check from reAssume to assumeDualImpl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81e44414aa92: [analyzer][NFC] Move overconstrained check from reAssume to assumeDualImpl (authored by martong). Repository: rG LLVM Github Monorep

[PATCH] D126707: [analyzer][NFC] Move overconstrained check from reAssume to assumeDualImpl

martong marked an inline comment as done. martong added a comment. In D126707#3549677 , @steakhal wrote: > LGTM; measure performance implications. Seems like there are no implications (or within the error margin). F23278565: image.png

[PATCH] D126707: [analyzer][NFC] Move overconstrained check from reAssume to assumeDualImpl

martong marked an inline comment as done. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:117-120 // Make internal constraint solver entities friends so they can access the // overconstrained-related functions

[PATCH] D126707: [analyzer][NFC] Move overconstrained check from reAssume to assumeDualImpl

steakhal added a comment. LGTM; measure performance implications. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h:117-120 // Make internal constraint solver entities friends so they can access the // overconstrained-related functions. We

[PATCH] D126707: [analyzer][NFC] Move overconstrained check from reAssume to assumeDualImpl

martong created this revision. martong added reviewers: steakhal, NoQ. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: