This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGefbf0136b410: Only issue warning for subtraction involving
null pointers on live code paths (authored by jamieschmeiser).
Repository:
rG LLVM Gith
jamieschmeiser updated this revision to Diff 433736.
jamieschmeiser edited the summary of this revision.
jamieschmeiser added a comment.
Respond to review comments: add cpp test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126816/new/
https://reviews.llvm.org/D126816
Files:
clang/l
anarazel added a comment.
So far the tests in pointer-subtraction.c are mirrored in
pointer-subtraction.cpp - worth continuing to do?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126816/new/
https://reviews.llvm.org/D126816
_
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126816/new/
https://reviews.llvm.org/D126816
___
jamieschmeiser created this revision.
jamieschmeiser added reviewers: anarazel, efriedma.
Herald added a project: All.
jamieschmeiser requested review of this revision.
Herald added a project: clang.
Change the warning produced for subtraction from (or with) a null pointer
to only be produced when
