[PATCH] D127184: [clangd] Add to header map

kadircet added a comment. we can also handle them through the stdlib symbol mappings, see https://github.com/llvm/llvm-project/issues/61373 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127184/new/ https://reviews.llvm.org/D127184 ___

[PATCH] D127184: [clangd] Add to header map

nridge added a comment. What is the status of this patch -- is it still relevant, and if so are there plans to finish/merge it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127184/new/ https://reviews.llvm.org/D127184 __

[PATCH] D127184: [clangd] Add to header map

falbrechtskirchinger added a comment. In D127184#3588226 , @nridge wrote: > In D127184#3577165 , > @falbrechtskirchinger wrote: > >> bits/mofunc_impl.h > > I see this included from `bits/move_only_function.h`, so

[PATCH] D127184: [clangd] Add to header map

sammccall added a comment. Apologies for not getting to this before vacation, and thanks Nathan for looking at this. (I'll leave for you to stamp) This is fine with me as-is, but I think this mapping shouldn't be our *preferred* way to solve this problem, and should eventually go away. We also

[PATCH] D127184: [clangd] Add to header map

nridge added a comment. Thanks for taking the time to do a systematic review! In D127184#3577165 , @falbrechtskirchinger wrote: > bits/mofunc_impl.h I see this included from `bits/move_only_function.h`, so I think `` would make sense for it. > bits/n

[PATCH] D127184: [clangd] Add to header map

falbrechtskirchinger updated this revision to Diff 436377. falbrechtskirchinger added a comment. Add more missing headers to the system header map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127184/new/ https://reviews.llvm.org/D127184 Files:

[PATCH] D127184: [clangd] Add to header map

falbrechtskirchinger added a comment. Since `*.tcc` files are mapped as well and there are only a few of them missing, should I add them as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127184/new/ https://reviews.llvm.org/D127184 _

[PATCH] D127184: [clangd] Add to header map

falbrechtskirchinger added a comment. Here's the preliminary list of mappings I've identified: "bits/align.h", "" "bits/atomic_wait.h", "" "bits/atomic_timed_wait.h", "" "bits/boost_concept_check.h", "" "bits/charconv.h", "" "bits/chrono.h", "" "bits/cow_string.h", "" "bits/fs_dir

[PATCH] D127184: [clangd] Add to header map

falbrechtskirchinger added a comment. In D127184#3572731 , @nridge wrote: > This change looks fine to me. > > I wonder though if we should be a bit more systematic about it, and try to > cover other newly added libstdc++ implementation headers? Sure thi

[PATCH] D127184: [clangd] Add to header map

nridge added a comment. This change looks fine to me. I wonder though if we should be a bit more systematic about it, and try to cover other newly added libstdc++ implementation headers? I checked out gcc's git repository, and ran: $ git diff --name-only --diff-filter=A releases/gcc-9.1.0 re

[PATCH] D127184: [clangd] Add to header map

falbrechtskirchinger created this revision. falbrechtskirchinger added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. falbrechtskirchinger requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.