xazax.hun added a comment.
In http://reviews.llvm.org/D12725#248931, @NoQ wrote:
> I've got no commit access yet, sorry, that's my first patch here actually :)
No problem, I committed it in r248021. Thank you for your contribution!
Repository:
rL LLVM
http://reviews.llvm.org/D12725
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248021: [analyzer] A fix for substraction of an integer from
a pointer. (authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D12725?vs=34423&id=35122#toc
Repository:
rL LLVM
http://
NoQ added a comment.
I've got no commit access yet, sorry, that's my first patch here actually :)
http://reviews.llvm.org/D12725
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun added a comment.
In http://reviews.llvm.org/D12725#243150, @NoQ wrote:
> Thanks, fixed :)
Can you commit this or do you need someone to commit this for you?
http://reviews.llvm.org/D12725
___
cfe-commits mailing list
cfe-commits@lists.l
NoQ added a comment.
Thanks, fixed :)
http://reviews.llvm.org/D12725
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ updated this revision to Diff 34423.
NoQ added a comment.
Make the tests easier to understand.
http://reviews.llvm.org/D12725
Files:
lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
test/Analysis/ptr-arith.c
Index: test/Analysis/ptr-arith.c
zaks.anna added a comment.
Let's make the test more explicit about what is being tested; for example,
void negativeIndex(char *str) {
char *ptr = str + 1;
*ptr = 'a';
clang_analyzer_eval(*ptr == 'a'); // expected-warning{{TRUE}}
ptr = str - 1;
clang_analyzer_eval(*ptr == 'a'); // expect
NoQ updated this revision to Diff 34320.
http://reviews.llvm.org/D12725
Files:
lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
test/Analysis/ptr-arith.c
Index: test/Analysis/ptr-arith.c
===
--- test/Analysis/ptr-arith.c
+++ test/A
