[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. In D127284#4303390 , @tahonermann wrote: > This change appears to have negatively impacted some users that were > dependent on the previous `Preprocessing::enableIncrementalPro

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

tahonermann added a comment. Herald added a subscriber: jplehr. This change appears to have negatively impacted some users that were dependent on the previous `Preprocessing::enableIncrementalProcessing(true)` behavior. See https://github.com/llvm/llvm-project/issues/62413. Repository: rG LL

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

UnionType added a comment. @v.g.vassilev Thanks for your reply, the patch is clean and clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 ___ cfe-commits m

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked an inline comment as done. v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/execute-stmts.cpp:34 + +for (; i > 4; --i) printf("i = %d\n", i); +// CHECK-NEXT: i = 5 UnionType wrote: > It seems that top-level statements wra

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

UnionType added inline comments. Comment at: clang/test/Interpreter/execute-stmts.cpp:34 + +for (; i > 4; --i) printf("i = %d\n", i); +// CHECK-NEXT: i = 5 It seems that top-level statements wrapped in braces cannot be handled, maybe I made a mistake. ``` for (;

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. > Latest test run: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48911/execution/node/74/log/ > I modified the expected string slightly to make it work: > https://reviews.llvm.org/rG811ad246ac7b > Should be all good now. Thanks for looking into this!

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

Michael137 added a comment. In D127284#3969975 , @v.g.vassilev wrote: > In D127284#3969593 , @Michael137 > wrote: > >> In D127284#3969458 , @v.g.vassilev >> wrote: >> >

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969593 , @Michael137 wrote: > In D127284#3969458 , @v.g.vassilev > wrote: > >> In D127284#3969446 , @v.g.vassilev >> wrote: >>

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

Michael137 added a comment. In D127284#3969458 , @v.g.vassilev wrote: > In D127284#3969446 , @v.g.vassilev > wrote: > >>> UPDATE: fails with clean build too >>> >>> Might be best to revert it for now while we fi

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969446 , @v.g.vassilev wrote: >> UPDATE: fails with clean build too >> >> Might be best to revert it for now while we figure out what's wrong > > I fail to reproduce it, can you give me access to some node where

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. > UPDATE: fails with clean build too > > Might be best to revert it for now while we figure out what's wrong I fail to reproduce it, can you give me access to some node where I can debug? I suspect that should be something easy to fix. Repository: rG LLVM Github

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969398 , @Michael137 wrote: > In D127284#3969308 , @v.g.vassilev > wrote: > >> In D127284#3969249 , @v.g.vassilev >> wrote: >>

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

Michael137 added a comment. In D127284#3969308 , @v.g.vassilev wrote: > In D127284#3969249 , @v.g.vassilev > wrote: > >> In D127284#3969225 , @Michael137 >> wrote: >> >

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969249 , @v.g.vassilev wrote: > In D127284#3969225 , @Michael137 > wrote: > >> FYI, looks like this broke the LLDB incremental buildbot. Following tests >> started fail

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. In D127284#3969225 , @Michael137 wrote: > FYI, looks like this broke the LLDB incremental buildbot. Following tests > started failing: > > > lldb-api.commands/expression/argument_passing_restrictions.TestArgumentPassingR

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

Michael137 added a comment. FYI, looks like this broke the LLDB incremental buildbot. Following tests started failing: lldb-api.commands/expression/argument_passing_restrictions.TestArgumentPassingRestrictions.py lldb-api.commands/expression/deleting-implicit-copy-constructor.TestDeletingI

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc4889357adb: [clang-repl] Support statements on global scope in incremental mode. (authored by v.g.vassilev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 ___ cfe-commits mailing lis

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 479390. v.g.vassilev added a comment. Herald added a subscriber: arphaman. Fixed the diff. I accidentally have added the commits from https://reviews.llvm.org/D139016 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.ll

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev planned changes to this revision. v.g.vassilev added a comment. I screwed up with the last diff. Let me fix it in a bit... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 ___ cfe-commits

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5395-5400 + // FIXME: Tell the user this is unsupported. + if (!Stmts.empty()) { +unsigned ID = Actions.getDiagnostics().getCustomDiagID( +DiagnosticsEngine::Error, "Unsupported statement

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 479310. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Address comments, fix a fixme. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/AST

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5395-5400 + // FIXME: Tell the user this is unsupported. + if (!Stmts.empty()) { +unsigned ID = Actions.getDiagnostics().getCustomDiagID( +DiagnosticsEngine::Error, "Unsupported statement

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked 3 inline comments as done. v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5395-5400 + // FIXME: Tell the user this is unsupported. + if (!Stmts.empty()) { +unsigned ID = Actions.getDiagnostics().getCustomDiagID( +Di

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:1782-1785 void enableIncrementalProcessing(bool value = true) { -IncrementalProcessing = value; +// FIXME: Drop this interface. +const_cast(getLangOpts()).IncrementalExtensions

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked an inline comment as done. v.g.vassilev added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1032-1034 +// FIXME: Remove the incremental processing pre-condition and verify clang +// still can pass its test suite, which will harden +// `is

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

rsmith added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1032-1034 +// FIXME: Remove the incremental processing pre-condition and verify clang +// still can pass its test suite, which will harden +// `isDeclarationStatement`. v.g.vassilev

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 478316. v.g.vassilev added a comment. rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/Decl.h clang/include/clang

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. I think I have addressed all comments from @aaron.ballman and @rsmith. Comment at: clang/include/clang/Lex/Preprocessor.h:1782-1785 void enableIncrementalProcessing(bool value = true) { -IncrementalProcessing = value; +// FIXME: Drop thi

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 478312. v.g.vassilev marked 10 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/Decl.h clang/inclu

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

rsmith added a comment. This is looking good to me. No further non-trivial concerns on my side. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6165 + // Stop squashing the top-level stmts into a single function. + if (CurCGF && !CXXGlobalInits.back()->getName().startswith("_

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added reviewers: efriedma, erichkeane. aaron.ballman added a comment. In general, this looks like an improvement over the last iteration (thank you for the suggestions, @rsmith!). I think this LGTM but there's enough changes in CodeGen that I'd appreciate a second set of eyes on th

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 477312. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Teach CodeGen to squash contiguous top-level stmt decl blocks into a single `llvm::Function`. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 477168. v.g.vassilev marked 2 inline comments as done. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. Address comments, support better C in clang-repl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ h

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

rsmith added inline comments. Comment at: clang/lib/AST/Decl.cpp:5264 + +FunctionDecl *TopLevelStmtDecl::getOrConvertToFunction() { + if (FD) I would hope that we can remove this. Instead, I think we can teach `CodeGen` to emit a sequence of `TopLevelStmtDecl`s

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 475470. v.g.vassilev marked an inline comment as not done. v.g.vassilev added a comment. Rebase + fix the failure on windows CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clan

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1033 +!isDeclarationStatement(/*DisambiguatingWithExpression=*/true)) + SingleDecl = ParseTopLevelStmtDecl(); + There is a remaining challenge which probably could be addresse

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 473496. v.g.vassilev added a comment. Remove several fixmes. Now we can deal with templates, deduction guides and operators. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/cla

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:-5568 + if (SS.isNotEmpty() && SS.getScopeRep()) { +NestedNameSpecifier *NNS = SS.getScopeRep(); +if (NNS->getAsNamespace() || NNS->getAsNamespaceAlias()) { + TPA.Revert(); + retu

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 473485. v.g.vassilev marked 2 inline comments as done. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. Address comments. Call `isCurrentClassName` before calling `isConstructorDeclarator`. CHANGES SINCE LAST ACTION htt

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

rsmith added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:-5568 + if (SS.isNotEmpty() && SS.getScopeRep()) { +NestedNameSpecifier *NNS = SS.getScopeRep(); +if (NNS->getAsNamespace() || NNS->getAsNamespaceAlias()) { + TPA.Revert(); + return fal

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked an inline comment as not done. v.g.vassilev added a comment. In D127284#3902487 , @aaron.ballman wrote: > It looks like precommit CI caught a relevant issue that should be addressed. Yes, I have a comment (starting with "The only rem

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a subscriber: akyrtzi. v.g.vassilev added inline comments. Comment at: clang/include/clang/Basic/DeclNodes.td:98 def FileScopeAsm : DeclNode; +def TopLevelStmt : DeclNode; def AccessSpec : DeclNode; aaron.ballman wrote: > Oh boy, that node na

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 472731. v.g.vassilev marked 21 inline comments as done. v.g.vassilev added a comment. Address more comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTNodeTra

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added a comment. It looks like precommit CI caught a relevant issue that should be addressed. Also, there's an in-progress patch that might be worth keeping an eye on in case it changes the behavior for clang-repl in bad ways: https://reviews.llvm.org/D137020 -- the patch causes u

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/disambiguate-decl-stmt.cpp:28-33 +namespace Ns {namespace Ns { void Ns(); void Fs();}} +void Ns::Ns::Ns() { printf("void Ns::Ns::Ns()\n"); } +void Ns::Ns::Fs() {} + +Ns::Ns::Fs(); +Ns::Ns::Ns(); --

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 472224. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTNodeTraverser.h cl

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 47. v.g.vassilev marked 4 inline comments as done. v.g.vassilev added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTNodeTraverser

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added a comment. In D127284#3776805 , @aaron.ballman wrote: > In D127284#3776036 , @rsmith wrote: > >> In terms of the high-level direction here, I think it would make sense to >> approach this by

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added a comment. In D127284#3776036 , @rsmith wrote: > In terms of the high-level direction here, I think it would make sense to > approach this by adding a full-fledged language extension to Clang to allow > statements at the top level (w

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

rsmith added a comment. In terms of the high-level direction here, I think it would make sense to approach this by adding a full-fledged language extension to Clang to allow statements at the top level (with a `-f` flag to enable it), and then enable that extension in the interpreter. The major

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/ASTConsumer.h:54-59 + /// HandleTopLevelStmts - Handle the specified top-level statements. This is + /// called by the parser to process every top-level Stmt* in incremental + /// compilation mode. + ///

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a subscriber: sunho. v.g.vassilev added inline comments. Comment at: clang/include/clang/AST/ASTConsumer.h:54-59 + /// HandleTopLevelStmts - Handle the specified top-level statements. This is + /// called by the parser to process every top-level Stmt* in incr

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 457830. v.g.vassilev marked 9 inline comments as done. v.g.vassilev added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTConsume

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added a comment. > The patch conceptually models the possible "top-level" statements between two > top-level declarations into a block which is emitted as part of the global > init function. > Currently we model this "statement block" as a function body to a void > function taking

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a reviewer: aaron.ballman. v.g.vassilev added a comment. Adding Aaron as a reviewer who hopefully could speed up the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 ___ cfe

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3381 &SS) && isConstructorDeclarator(/*Unqualified*/ false)) goto DoneWithDeclSpec; The only remaining failure is in `test/Pars

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 449066. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. Herald added subscribers: sstefan1, Anastasia. Herald added a reviewer: jdoerfert. Rely on the CXXScopeSpec to detect more accurately if we are parsing a constructor

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 447120. v.g.vassilev retitled this revision from "[WIP] [clang-repl] Support statements on global scope in incremental mode." to "[clang-repl] Support statements on global scope in incremental mode.". v.g.vassilev edited the summary of this revision. v.g