This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6a6484c666ed: [OpenMP] Fix offload packager not writing to
temps correctly (authored by jhuber6).
Repository:
rG LLVM Github Monorepo
CHANGES SIN
jhuber6 updated this revision to Diff 436493.
jhuber6 added a comment.
Addressing nits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127673/new/
https://reviews.llvm.org/D127673
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/openmp-offl
jhuber6 marked an inline comment as done.
jhuber6 added a comment.
Thanks for the review.
Comment at: clang/lib/Driver/Driver.cpp:5420
+/*CreatePrefixForHost=*/isa(A) ||
+(!!A->getOffloadingHostActiveKinds() && !AtTopLevel));
if (isa(JA)) {
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM overall with a couple of nits.
Comment at: clang/lib/Driver/Driver.cpp:5420
+/*CreatePrefixForHost=*/isa(A) ||
+(!!A->getOffloadingHostActiveKinds() && !At
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, tra.
Herald added a subscriber: guansong.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1, MaskRay.
Herald added a project: clang.
The
