kito-cheng accepted this revision.
kito-cheng added a comment.
This revision is now accepted and ready to land.
ld's help message just confused me, that say `-X` is default, but actually
default action is `Discard local temporary symbols in SEC_MERGE sections.`
which is no option can enable that
MaskRay added a comment.
Thanks for the archaeology!
> ld will treat ld -r -s as ld -r -S -x,
This seems really weird... I agree that using driver-passed -X instead of the
implied -x is safe.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127826/n
MaskRay added a subscriber: dim.
MaskRay added inline comments.
Comment at: clang/lib/Driver/ToolChains/FreeBSD.cpp:226
CmdArgs.push_back("elf32lriscv");
+CmdArgs.push_back("-X");
break;
@dim FYI
Repository:
rG LLVM Github Monorepo
CHANGES SINC
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc324c938becd: [Driver] Pass -X to ld for
riscv*-{elf,freebsd,linux} (authored by MaskRay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
brad added a comment.
This should probably be applied to Fuchsia and NetBSD as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127826/new/
https://reviews.llvm.org/D127826
___
cfe-commits mailing lis
MaskRay created this revision.
Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr,
frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim,
benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,
edward-jones, zzheng, jrtc27, shiva0217,
