thanks for the revert, you beat me to it.
On Fri, Jun 17, 2022 at 3:07 PM Nico Weber via Phabricator <
revi...@reviews.llvm.org> wrote:
> thakis added a comment.
>
> Before landing changes, please:
>
> - Run tests
> - Look at the result from the presubmit checks
>
> After landing changes, please
thakis added a comment.
Before landing changes, please:
- Run tests
- Look at the result from the presubmit checks
After landing changes, please watch your favorite bot cycle green with it, and
pay attention for buildbot email for a while.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
CarlosAlbertoEnciso added a comment.
@kadircet It seems that your change broke couple of clang tests:
https://lab.llvm.org/buildbot/#/builders/109/builds/40797
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127863/new/
https://reviews.llvm.org/D127
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG32805e60c9de: [clang] Dont print implicit forrange
initializer (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACT
usaxena95 accepted this revision.
usaxena95 added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127863/new/
https://reviews.llvm.org/D127863
__
kadircet created this revision.
kadircet added a reviewer: usaxena95.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, ilya-biryukov.
Herald added a project: clang.
Fixes https://github.com/clangd/clangd/issues/1158
Repository:
rG
