This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2d43de13df03: [AMDGPU] gfx11 new dot instruction codegen
support (authored by Joe_Nash).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127904/new/
https://reviews.llvm.org/D127904
___
Joe_Nash added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1926
+// f16 %r = llvm.amdgcn.fdot2.f16.f16(v2f16 %a, v2f16 %b, f16 %c, i1 %clamp)
+// %r = %a[0] * %b[0] + %a[1] * %b[1] + %c
rampitec wrote:
> I do not see clamp in the def
Joe_Nash updated this revision to Diff 437552.
Joe_Nash marked 3 inline comments as done.
Joe_Nash added a comment.
added builtin positive tests, removed clamp from intrinsic comments, combined
gisel with normal codegen test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
rampitec added inline comments.
Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-dl-insts-err.cl:1
// REQUIRES: amdgpu-registered-target
Also need positive tests like in builtins-amdgcn-dl-insts.cl.
Comment at: llvm/include/llvm/IR/Intri
arsenm added inline comments.
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.fdot2.f16.f16.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1100 -verify-machineinstrs < %s
| FileCheck
Joe_Nash created this revision.
Joe_Nash added reviewers: foad, rampitec.
Herald added subscribers: kosarev, jsilvanus, hsmhsm, kerbowa, hiraditya,
t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm.
Herald added a project: All.
Joe_Nash requested review of this revision.
Herald ad
