Re: [PATCH] D12793: Three new overflow builtins with generic argument types

2015-10-30 Thread David Grayson via cfe-commits
DavidEGrayson added a comment. Thanks, John! Looks like it's actually committed in rL251651 . Thanks for handling the volatile pointers correctly (I didn't know I had to do something special for them) and giving me credit in the commit message!

Re: [PATCH] D12793: Three new overflow builtins with generic argument types

2015-10-29 Thread John McCall via cfe-commits
rjmccall added a comment. Sorry for the delay. Committed with a few minor tweaks in r251650. http://reviews.llvm.org/D12793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12793: Three new overflow builtins with generic argument types

2015-10-27 Thread David Grayson via cfe-commits
DavidEGrayson added a comment. Ping. http://reviews.llvm.org/D12793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12793: Three new overflow builtins with generic argument types

2015-10-07 Thread David Grayson via cfe-commits
DavidEGrayson marked an inline comment as done. DavidEGrayson added a comment. Well, it has been another week. John, I don't have commit access, so can you commit this? Thanks! Let me know if the patch doesn't apply cleanly or any tests fail. http://reviews.llvm.org/D12793

Re: [PATCH] D12793: Three new overflow builtins with generic argument types

2015-09-30 Thread David Grayson via cfe-commits
DavidEGrayson updated this revision to Diff 36117. DavidEGrayson added a comment. I changed the patch in two ways: it now returns ExprError() is the third argument is wrong (for consistency with the other argument checking code). I removed an outdated comment for EncompassingIntegerType.

Re: [PATCH] D12793: Three new overflow builtins with generic argument types

2015-09-29 Thread David Grayson via cfe-commits
DavidEGrayson added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:303 @@ +302,3 @@ +// the first element is the bit width of an integer type and the second element +// is true if the integer type is signed. +static struct WidthAndSignedness Sorry, I need

Re: [PATCH] D12793: Three new overflow builtins with generic argument types

2015-09-28 Thread John McCall via cfe-commits
rjmccall added a comment. LGTM, thanks. http://reviews.llvm.org/D12793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits