[PATCH] D128142: [MemProf] Memprof profile matching and annotation

eopXD added a comment. Please disregard my previous comment, I missed the latest commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128142/new/ https://reviews.llvm.org/D128142 ___ cfe-commits mailing

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

eopXD added a comment. I see that this revision is reverted along with reversion of D128143 , I see that D128143 is re-commited. The commit message of D128143 says that it depends on this pat

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1247 +uint32_t Column) { + return hash_combine(Function, LineOffset, Column); +} M

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1247 +uint32_t Column) { + return hash_combine(Function, LineOffset, Column); +} MaskRay wrote: > You may use BLAKE3 instead of

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1247 +uint32_t Column) { + return hash_combine(Function, LineOffset, Column); +} You may use BLAKE3 instead of MD5. BLAKE3 is mu

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa212d8da94d0: [MemProf] Memprof profile matching and annotation (authored by tejohnson). Changed prior to commit: https://reviews.llvm.org/D128142

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

snehasish accepted this revision. snehasish added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1276 + if (Error E = MemProfResult.takeError()) { +handleAllErrors(std::move(E), [&](co

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson updated this revision to Diff 456710. tejohnson marked 5 inline comments as done. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128142/new/ https://reviews.llvm.org/D128142 Files: clang/lib/F

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson marked 12 inline comments as done. tejohnson added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1252 +AllocInfo->Info.getMinLifetime()); + SmallVector StackIds; + std::set StackHashSet; ---

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

snehasish added inline comments. Herald added a subscriber: mingmingl. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1249 +void addCallStack(CallStackTrie &AllocTrie, const AllocationInfo *AllocInfo) { + auto AllocType = getAllocType(AllocInfo->Info.getM

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson added inline comments. Comment at: clang/test/CodeGen/memprof.cpp:15 +// # Collect memory profile: +// $ clang++ -fuse-ld=lld -Wl,-no-pie -Wl,--no-rosegment -gmlt \ +// -fdebug-info-for-profiling -mno-omit-leaf-frame-pointer \ snehasish wrote: > Ju

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson updated this revision to Diff 446986. tejohnson marked 3 inline comments as done. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128142/new/ https://reviews.llvm.org/D128142 Files: clang/lib/F

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

Enna1 added inline comments. Comment at: llvm/lib/Analysis/MemoryBuiltins.cpp:288-290 +bool llvm::isNewLikeFn(const Value *V, const TargetLibraryInfo *TLI) { + return getAllocationData(V, OpNewLike, TLI).hasValue(); +} nit: place the definition of `llvm::isNewLi

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson updated this revision to Diff 441529. tejohnson marked 3 inline comments as done. tejohnson added a comment. Rebase on top of D128854 which now includes the extracted Analysis utilities. I have not yet addressed the other comments on this patch. Repo

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson marked 3 inline comments as done. tejohnson added inline comments. Comment at: llvm/include/llvm/Analysis/MemoryProfileInfo.h:1 +//===- llvm/Analysis/MemoryProfileInfo.h - memory profile info ---*- C++ -*-==// +// snehasish wrote: > Can you split out t

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

snehasish added a comment. I'm still going through PGOInstrumentation.cpp ... Comment at: clang/test/CodeGen/memprof.cpp:15 +// # Collect memory profile: +// $ clang++ -fuse-ld=lld -Wl,-no-pie -Wl,--no-rosegment -gmlt \ +// -fdebug-info-for-profiling -mno-omit-leaf-frame-p

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson created this revision. tejohnson added reviewers: snehasish, davidxl. Herald added subscribers: Enna1, wenlei, hiraditya, mgorny. Herald added a project: All. tejohnson requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Profile