[PATCH] D128235: [RISCV] Add support for the Zawrs extension

palmer-dabbelt added a comment. I was talking to @reames about this. The spec has changed since I posted these patches: there's now two instructions (wrs.nto and wrs.sto) and there's no longer a register to encode the timeout. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128235/new/

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

asb added a comment. > This is still some sort of very early draft and I'm not sure what the rules > are in LLVM land for merging that sort of code. It's a fast track extension > so it should be done soon The policy we ended up with is that support for not-yet-ratified extensions can be merged

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

kito-cheng added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:195 + if (ISAInfo->hasExtension("zawrs")) +Builder.defineMacro("__riscv_zawrs"); } You don't need this line, that would be defined automatically once you've add `zawrs` in `RI

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

MaskRay added inline comments. Comment at: llvm/test/MC/RISCV/zawrs-invalid.s:4 +# WRS doesn't take immediates +wrs 1 # CHECK: :[[@LINE]]:5: error: invalid operand for instruction + `[[@LINE]]` is a deprecated FileCheck feature. Use `[[#@LINE]]` Note: you can p

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

MaskRay added a comment. > Context not available. See `-U99` on https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface or use `arc diff` (PHP 8 may need https://discourse.llvm.org/t/arcanist-deprecation-errors-on-php-8/63231) Comment at: llvm/t

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

craig.topper added inline comments. Comment at: clang/test/Driver/riscv-arch.c:585 +// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZAWRS-GOOD %s +// RV32-ZHINX-GOOD: "-target-feature" "+zawrs" + This doesn't match the RUN line Commen

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

eopXD added a comment. Looks like the patch application failed, might need to rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128235/new/ https://reviews.llvm.org/D128235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

palmer-dabbelt updated this revision to Diff 438515. palmer-dabbelt added a comment. Herald added a subscriber: jdoerfert. - Fix a whitespace issue - Fix the name of RISCVInstrInfoZawrs.td - Call the #define __riscv_zawrs instead of __riscv_wrs, to match the others - Add tests in clang/test/Driver

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

eopXD added a comment. - I think we will need some test coverage under `llvm/test/CodeGen/RISCV/attributes.ll` and `llvm/test/MC/RISCV/attribute-arch.s` if the extension is existing in the arch string. - Since macro is added, we need some test coverage under `clang/test/Preprocessor/riscv-targ

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

eopXD added a comment. In D128235#3597645 , @palmer-dabbelt wrote: > I've never touched LLVM before, so I have no idea if I'm even in the right > place here... Yes, you are in the right place. All LLVM patches go through the Phabricator. A patch goes i

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZawrs.td:1 +//===-- RISCVInstrInfoM.td - RISC-V 'M' instructions ---*- tablegen -*-===// +// This doesn't match the filename. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

palmer-dabbelt added a comment. I've never touched LLVM before, so I have no idea if I'm even in the right place here... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128235/new/ https://reviews.llvm.org/D128235 __

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

palmer-dabbelt created this revision. palmer-dabbelt added reviewers: reames, asb. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,