[PATCH] D128319: Survive #pragma once from virtual file.

aaron.ballman added a comment. In D128319#3615779 , @v.g.vassilev wrote: > Historically, the patch was developed before the extended support of virtual > files in Clang. Given that this is very hard to test and it looks like this > is not needed on

[PATCH] D128319: Survive #pragma once from virtual file.

v.g.vassilev added a comment. Historically, the patch was developed before the extended support of virtual files in Clang. Given that this is very hard to test and it looks like this is not needed on our end anymore. I'd propose to pause this for now. Repository: rG LLVM Github Monorepo

[PATCH] D128319: Survive #pragma once from virtual file.

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. +1, this needs some test coverage for the changes. It should also have a release note to notify users of the fix. Comment at: clang/lib/Lex/Pragma.cpp:415-419 + if

[PATCH] D128319: Survive #pragma once from virtual file.

v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a comment. Can we write a test for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128319/new/ https://reviews.llvm.org/D128319 ___

[PATCH] D128319: Survive #pragma once from virtual file.

tapaswenipathak created this revision. tapaswenipathak added a reviewer: v.g.vassilev. tapaswenipathak added a project: clang. Herald added a project: All. tapaswenipathak requested review of this revision. Herald added a subscriber: cfe-commits. Add check before marking file as a once-only file.