[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f0578dd87ee: [clang-cl] Add -emit-ast to clang-cl driver (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

hans accepted this revision. hans added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 440243. thieta added a comment. Updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409 Files: clang/include/clang/Driver/Options.td

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 440242. thieta added a comment. Just handle /o for AST and plist files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409 Files: clang/include/clang/Driver/Options.td

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

hans added a comment. > Regarding /Fo bit - if you want I can change it to only handle /o in this if > statement. I don't mind either way. Just doing `/o` seems better. Thanks. Comment at: clang/test/Driver/ast.c:30 +// Also check clang-cl since the driver is slightly

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta added a comment. Fixed the test issue. Regarding `/Fo` bit - if you want I can change it to only handle `/o` in this if statement. I don't mind either way. Comment at: clang/test/Driver/ast.c:30 +// Also check clang-cl since the driver is slightly different +// RUN:

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 440227. thieta added a comment. Fixed missing -- in test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409 Files: clang/include/clang/Driver/Options.td

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. It feels kind of weird to use the `/Fo` option for this that's for object files, but if that makes using the static analyzer more convenient that's okay I suppose. Comment at:

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 440178. thieta added a comment. Added tests and moved the check for TY_Plist and TY_AST to it's own if statement block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

hans added a comment. In D128409#3604570 , @thieta wrote: > In D128409#3604460 , @hans wrote: > >> I'm unfamiliar with -emit-ast. Can you add some background on what this is >> for? What's CTU? > > CTU is cross

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 439341. thieta added a comment. Removed unintentional whitespace removal and landed that as a NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409 Files:

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta added a comment. In D128409#3604460 , @hans wrote: > I'm unfamiliar with -emit-ast. Can you add some background on what this is > for? What's CTU? CTU is cross translation unit. In this case the clang-static-analyzer can do analysis over

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

hans added a comment. I'm unfamiliar with -emit-ast. Can you add some background on what this is for? What's CTU? In any case this needs a test. Comment at: clang/include/clang/Driver/Options.td:834 def Xoffload_linker : JoinedAndSeparate<["-"], "Xoffload-linker">, -

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta added inline comments. Comment at: clang/include/clang/Driver/Options.td:834 def Xoffload_linker : JoinedAndSeparate<["-"], "Xoffload-linker">, - HelpText<"Pass to the offload linkers or the ones idenfied by -">, + HelpText<"Pass to the offload linkers or the ones

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta created this revision. thieta added reviewers: hans, mstorsjo. Herald added a project: All. thieta requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. Also make the output of -emit-ast end up where /Fo or /o points. The same with .plist