[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

2022-08-05 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D128441#3702816 , @jhuber6 wrote: > Is it spitting it out as `foo123.cubin` instead? That's the output name it passes to `ptxas`, but it's treated as a temporary file and is removed at the end, so the user gets nothing. Reposit

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

2022-08-05 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D128441#3702800 , @tra wrote: > This change breaks `clang++ --cuda-device-only` compilation. Clang does not > create any output in this case. Reverting the change fixes the problem. > > Reproducible with: > > echo '__global

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

2022-08-05 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. This change breaks `clang++ --cuda-device-only` compilation. Clang does not create any output in this case. Reverting the change fixes the problem. Reproducible with: echo '__global__ void k(){}' | bin/clang++ --offload-arch=sm_70 -x cuda - --cuda-device-only -v -c -

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

2022-06-23 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d3c010f1d01: [CUDA] Do not embed a fatbinary when using the new driver (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

2022-06-23 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D128441#3605809 , @tra wrote: >> The linker wrapper cannot do anything with these embedded PTX files because >> we do not know how to link them, > > Neither, apparently does `nvlink`. It does have `--emip-ptx ` option, > but

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

2022-06-23 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. > The linker wrapper cannot do anything with these embedded PTX files because > we do not know how to link them, Neither, apparently does `nvlink`. It does have `--emip-ptx ` option, but only if LT

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

2022-06-23 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 439384. jhuber6 added a comment. Remove comment that is no longer true now that `getInputFilename` always returns a `.cubin` variant for object types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128441/new/

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

2022-06-23 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. Previousl