[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fff116645b3: [OpenMP] Change OpenMP code generation for target region entries (authored by jhuber6). Repository: rG LLVM Github Monorepo

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 443011. jhuber6 added a comment. Moving version field to struct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 441048. jhuber6 added a comment. Update with new version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 440831. jhuber6 added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 440822. jhuber6 added a comment. Herald added subscribers: mattd, asavonic. Fix tests, lots of lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files:

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 439853. jhuber6 added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 updated this revision to Diff 439851. jhuber6 added a comment. Simplify interface now that we use -1 to indicate a lack of teams. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128550/new/ https://reviews.llvm.org/D128550 Files:

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6720-6722 } else if (DefaultNT == -1) { -return nullptr; +return llvm::ConstantInt::get(CGF.Int32Ty, -1); } This code can be removed safely in this form Repository:

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 added a comment. This currently fails about 180 Clang tests. Of those about half can be automatically updated. I tried to manually update the other 90 but gave up, attempting to auto generate those tests as well would most likely result in over half a million new lined added to LLVM,

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

jhuber6 created this revision. jhuber6 added reviewers: ABataev, JonChesterfield, jdoerfert, tianshilei1992. Herald added subscribers: guansong, hiraditya, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1.