[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

arichardson added inline comments. Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:54 + + // Set alias for "riscv{64|32}-unknown-unknown-elf" + SmallVector TripleAliases; anton-afanasyev wrote: > arichardson wrote: > > This seems like the wrong place

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

anton-afanasyev marked an inline comment as done. anton-afanasyev added inline comments. Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:54 + + // Set alias for "riscv{64|32}-unknown-unknown-elf" + SmallVector TripleAliases; arichardson wrote: > This

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

arichardson added inline comments. Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:54 + + // Set alias for "riscv{64|32}-unknown-unknown-elf" + SmallVector TripleAliases; This seems like the wrong place to add this workaround, shouldn't the change be

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

anton-afanasyev added a comment. In D128625#3621030 , @MaskRay wrote: > The description seems unclear to me. Is a `riscv64-unknown-linux-gnu` GCC > installation selected while the requested target triple is > `riscv64-unknown-elf`? Yes, exactly (see pr

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

MaskRay added a comment. The description seems unclear to me. Is a `riscv64-unknown-linux-gnu` GCC installation selected while the requested target triple is `riscv64-unknown-elf`? This could be an instance of https://discourse.llvm.org/t/rfc-fix-loose-behaviors-of-clang-target/60272 (`[RFC] F

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, `riscv*-unknown-unknown` match `riscv*-unknown-elf` sound make more sense than `riscv*-unknown-linux-gnu` :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

anton-afanasyev created this revision. anton-afanasyev added reviewers: MaskRay, kito-cheng, asb. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, abidh, jocewei, PkmX, the_o, bruce