vsapsai added a comment.
Thanks for the review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128690/new/
https://reviews.llvm.org/D128690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf693874c53c1: [ODRHash diagnostics] Preparation to minimize
subsequent diffs. NFC. (authored by vsapsai).
Repository:
rG LLVM Github Monorepo
CHA
vsapsai updated this revision to Diff 444787.
vsapsai added a comment.
Rebase and unhoist `ComputeTemplateParameterListODRHash`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128690/new/
https://reviews.llvm.org/D128690
Files:
clang/lib/Serializ
ChuanqiXu added inline comments.
Comment at: clang/lib/Serialization/ASTReader.cpp:10621-10626
// Compute the hash of the method as if it has no body.
-auto ComputeCXXMethodODRHash = [&Hash](const CXXMethodDecl *D) {
- Hash.clear();
- Hash.AddFu
vsapsai added inline comments.
Comment at: clang/lib/Serialization/ASTReader.cpp:10621-10626
// Compute the hash of the method as if it has no body.
-auto ComputeCXXMethodODRHash = [&Hash](const CXXMethodDecl *D) {
- Hash.clear();
- Hash.AddFunc
ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.
LGTM basically.
Comment at: clang/lib/Serialization/ASTReader.cpp:10621-10626
// Compute the hash of the method as if it has no body.
-auto ComputeCXXM
vsapsai updated this revision to Diff 443403.
vsapsai added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128690/new/
https://reviews.llvm.org/D128690
Files:
clang/lib/Serialization/ASTReader.cpp
Index: clang/lib/Serializatio
vsapsai updated this revision to Diff 440451.
vsapsai added a comment.
More preparations to minimize subsequent diff.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128690/new/
https://reviews.llvm.org/D128690
Files:
clang/lib/Serialization/ASTRe
vsapsai created this revision.
Herald added a subscriber: ributzka.
Herald added a project: All.
vsapsai requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Specifically, making the following changes:
- Turn lambdas calculating ODR hashes into
