sfantao closed this revision.
sfantao added a comment.
Committed in r249148!
Thanks,
Samuel
http://reviews.llvm.org/D12871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+Sizes.push_back(Size);
+MapTypes.push_back(MapType);
+ }
+
+ // Keep track on whether the host function has to be executed.
+ auto OffloadErrorQType =
+ CGF.getCont
sfantao updated this revision to Diff 36317.
sfantao added a comment.
Address Alexey's remarks from last review.
http://reviews.llvm.org/D12871
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunction.h
test/OpenMP/t
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+Sizes.push_back(Size);
+MapTypes.push_back(MapType);
+ }
+
+ // Keep track on whether the host function has to be executed.
+ auto OffloadErrorQType =
+ CGF.getCont
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+
+ if (auto *VAT = dyn_cast(ElementType.getTypePtr())) {
+auto VATInfo = CGF.getVLASize(VAT);
+Size = llvm::ConstantInt::get(
+CGM.SizeTy,
+
sfantao updated this revision to Diff 35121.
sfantao added a comment.
Update if clause emission for target directive following Alexey's remark.
http://reviews.llvm.org/D12871
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/Co
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+
+ if (auto *VAT = dyn_cast(ElementType.getTypePtr())) {
+auto VATInfo = CGF.getVLASize(VAT);
+Size = llvm::ConstantInt::get(
+CGM.SizeTy,
+
sfantao added inline comments.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:121-123
@@ -103,4 +120,5 @@
+ArgLVal.getAddress(), ArgLVal.getType()->castAs());
auto *ExprArg =
EmitLoadOfLValue(ArgLVal, SourceLocation()).getScalarVal();
auto VAT = FD->
sfantao updated this revision to Diff 34936.
sfantao added a comment.
Fix imprecision in previous diff.
http://reviews.llvm.org/D12871
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunction.h
test/OpenMP/target_cod
sfantao added inline comments.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:80-81
@@ -67,1 +79,4 @@
II = &getContext().Idents.get("vla");
+ if (UseOnlyReferences)
+ArgType = getContext().getLValueReferenceType(
+ArgType, /*SpelledAsLValue=*/false);
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+
+ if (auto *VAT = dyn_cast(ElementType.getTypePtr())) {
+auto VATInfo = CGF.getVLASize(VAT);
+Size = llvm::ConstantInt::get(
+CGM.SizeTy,
+
sfantao updated this revision to Diff 34933.
sfantao added a comment.
Minor changes to address Alexey's remarks.
http://reviews.llvm.org/D12871
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunction.h
test/OpenMP/t
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+
+ if (auto *VAT = dyn_cast(ElementType.getTypePtr())) {
+auto VATInfo = CGF.getVLASize(VAT);
+Size = llvm::ConstantInt::get(
+CGM.SizeTy,
+
sfantao updated this revision to Diff 34869.
sfantao added a comment.
Update code to use implicit parameters for the captured variables using
`GenerateOpenMPCapturedStmtFunction`, similarly to what is done to other
directives.
`UseOnlyReferences` boolean was added to `GenerateOpenMPCapturedStm
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, rjmccall.
sfantao added subscribers: cfe-commits, Hahnfeld.
This patch rebases and creates a new revision for
http://reviews.llvm.org/D11361 as requested by John.
Here's the adapted original summary (the global captures is
15 matches
Mail list logo
