[PATCH] D128981: [C++20][Modules] Implement include translation.

jansvoboda11 added a comment. Thank you! Yes, I think this would be a good candidate for backporting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128981/new/ https://reviews.llvm.org/D128981 ___ cfe-co

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains added a comment. In D128981#3728503 , @iains wrote: > In D128981#3728070 , @jansvoboda11 > wrote: > >> Hi @iains, upstream Clang crashes on the attached test case due to an >> assertion failure. Git bisect

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains added a comment. In D128981#3728070 , @jansvoboda11 wrote: > Hi @iains, upstream Clang crashes on the attached test case due to an > assertion failure. Git bisect pointed me to this commit. Can you please take > a look? Previously, the test would

[PATCH] D128981: [C++20][Modules] Implement include translation.

jansvoboda11 added a comment. Hi @iains, upstream Clang crashes on the attached test case due to an assertion failure. Git bisect pointed me to this commit. Can you please take a look? Previously, the test would result in a warning of incomplete umbrella header. // RUN: rm -rf %t && mkdir %t

[PATCH] D128981: [C++20][Modules] Implement include translation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf2d11b1d5c1: [C++20][Modules] Implement include translation. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128981/new/ https://reviews

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains updated this revision to Diff 442242. iains added a comment. addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128981/new/ https://reviews.llvm.org/D128981 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Le

[PATCH] D128981: [C++20][Modules] Implement include translation.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Then LGTM if all the comments addressed. Comment at: clang/lib/Lex/PPDirectives.cpp:2226-2227 + + // FIXME: We do not have a good way to disambiguate C++ clang modules

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains marked an inline comment as done. iains added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:2226-2227 + + // FIXME: We do not have a good way to disambiguate C++ clang modules from + // C++ standard modules (other than use/non-use of Header Units). + Module

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains updated this revision to Diff 442085. iains marked 7 inline comments as done. iains added a comment. rebased, addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128981/new/ https://reviews.llvm.org/D128981 Files: clan

[PATCH] D128981: [C++20][Modules] Implement include translation.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:434 +/// Saw a 'module' identifier. +void handleModule(bool ATLTS) { + // This was the first module identifier and not preceded by any token iains wrote: > ChuanqiXu

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains marked 3 inline comments as done. iains added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:434 +/// Saw a 'module' identifier. +void handleModule(bool ATLTS) { + // This was the first module identifier and not preceded by any token --

[PATCH] D128981: [C++20][Modules] Implement include translation.

ChuanqiXu added a subscriber: rsmith. ChuanqiXu added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:434 +/// Saw a 'module' identifier. +void handleModule(bool ATLTS) { + // This was the first module identifier and not preceded by any token

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains updated this revision to Diff 441871. iains added a comment. fix a state transition after include translation. This update fixes an (apparently pre-existing) bug in handling: module; #include "translated-header.h" import "header-unit.h"; The translation process pushes a tok::annot

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains created this revision. Herald added a project: All. iains requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This addresses [cpp.include]/7 (when encountering #include header-name) If the header identified by the header-name denotes an