john.brawn added a comment.
In http://reviews.llvm.org/D12903#247934, @compnerd wrote:
> While I agree that this makes the option much nicer to use, it collides with
> the -l flag. Since it was an internal only option until this point, we
> should rename it before exposing it at the driver lev
compnerd added a subscriber: compnerd.
compnerd added a comment.
While I agree that this makes the option much nicer to use, it collides with
the -l flag. Since it was an internal only option until this point, we should
rename it before exposing it at the driver level.
Repository:
rL LLVM
rengolin added a comment.
Hi John,
Looks all right to me, but I don't want to approve without someone more
familiar with the -load option to agree that this is not an exclusively
internal option.
Other than that, I'm happy with it.
cheers,
--renato
Repository:
rL LLVM
http://reviews.llvm
john.brawn updated this revision to Diff 34977.
john.brawn added a comment.
Add a test.
Repository:
rL LLVM
http://reviews.llvm.org/D12903
Files:
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
lib/Driver/Tools.cpp
test/Driver/load.c
Index: test/Driver/load.c
rengolin added a comment.
In http://reviews.llvm.org/D12903#247075, @john.brawn wrote:
> The use-case is loading llvm plugins that add optimization passes via the
> PassManagerBuilder::addGlobalExtension mechanism (i.e. just loading the
> plugin is enough and you don't have to add anything extr
john.brawn added a comment.
In http://reviews.llvm.org/D12903#247055, @rengolin wrote:
> Hi John,
>
> Can you expand a bit more on why you need this, what's the use case, and
> hopefully attach a test for them?
The use-case is loading llvm plugins that add optimization passes via the
PassMana
rengolin added a subscriber: rengolin.
rengolin added a comment.
Hi John,
Can you expand a bit more on why you need this, what's the use case, and
hopefully attach a test for them?
cheers,
--renato
Repository:
rL LLVM
http://reviews.llvm.org/D12903
__
john.brawn created this revision.
john.brawn added a subscriber: cfe-commits.
john.brawn set the repository for this revision to rL LLVM.
Currently -load is only allowed in the -cc1 command, which makes it rather
awkward to use. Allowing it in the driver and passing it through to -cc1 is
much mo