[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

aaronpuchert added a comment. In D129160#3721943 , @isuruf wrote: > Sure. If an application links to `libclang.so` when the application is being > built, the application will hardcode `libclang.so.13` in it and will look for > it. > When the SONAME chan

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

isuruf added a comment. > Could you elaborate on this? Sure. If an application links to `libclang.so` when the application is being built, the application will hardcode `libclang.so.13` in it and will look for it. When the SONAME changes to `libclang.so.15` in LLVM 15, the application will not

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

aaronpuchert added a comment. > Also, this change did not really acheive it's purpose of allowing apps to use > newer versions of libclang.so without rebuilding, because a new version of > libclang.so requires a new version of libLLVM.so, which does not have a > stable ABI. Could you elaborate

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

h-vetinari added a comment. In D129160#3716826 , @isuruf wrote: > Maybe this should be a cmake option that is off by default and I can turn it > for my builds? I proposed something along those lines in https://discourse.llvm.org/t/rationale-for-removin

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

isuruf added a comment. Maybe this should be a cmake option that is off by default and I can turn it for my builds? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129160/new/ https://reviews.llvm.org/D129160 ___

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

MaskRay added a comment. In D129160#3716016 , @isuruf wrote: > As a downstream packager of libclang, I really like the SONAME not changing > in libclang. It makes it possible for us to package things like qt that > depend on libclang, but not have to re

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

isuruf added a comment. As a downstream packager of libclang, I really like the SONAME not changing in libclang. It makes it possible for us to package things like qt that depend on libclang, but not have to rebuild qt for every major revision of LLVM. It's not clear to me what the reason for re

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc39d7bdd497: libclang.so: Make SONAME the same as LLVM version (authored by tstellar). Changed prior to commit: https://reviews.llvm.org/D129160?vs=444843&id=447566#toc Repository: rG LLVM Github Mo

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar added a comment. In D129160#3678441 , @h-vetinari wrote: > In D129160#3678431 , @tstellar > wrote: > >> @h-vetinari Does the release note look OK? > > Basically yes, thank you! I'd still be more precise

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

h-vetinari added a comment. In D129160#3678431 , @tstellar wrote: > @h-vetinari Does the release note look OK? Basically yes, thank you! I'd still be more precise and say "soversion" rather than "soname", but otherwise OK. Repository: rG LLVM Github

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar added a comment. @h-vetinari Does the release note look OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129160/new/ https://reviews.llvm.org/D129160 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar updated this revision to Diff 444843. tstellar added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129160/new/ https://reviews.llvm.org/D129160 Files: clang/docs/ReleaseNotes.rst clang/tools/libclang/CMake

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

h-vetinari added a comment. Forgot to mention it before: would be good to note this in the release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129160/new/ https://reviews.llvm.org/D129160 ___ cfe

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. I have seen multiple reports that distributors found this behavior change surprising. I agree that having this more complex symbol versioning with libclang.so probably doesn't improve

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

h-vetinari added a comment. Thanks for the ping. It's unfortunate that this didn't work out as intended. It's certainly fine though (for our purposes) to go back to the way things were before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129160/n

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar created this revision. tstellar added reviewers: MaskRay, h-vetinari. Herald added subscribers: StephenFan, fedor.sergeev, mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This partially