njames93 added a comment.
This appears to be causing a crash with friend declarations. The crash happens
during matching, see https://github.com/llvm/llvm-project/issues/56902
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129353/new/
https://revie
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0e95921bc303: [clang-tidy] Improve check cert-dcl58-cpp.
(authored by balazske).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129353/new/
https://reviews.l
balazske updated this revision to Diff 444165.
balazske marked 3 inline comments as done.
balazske added a comment.
Added comments, removed unneeded AST matcher code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129353/new/
https://reviews.llvm.or
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with some minor nits.
Comment at:
clang-tools-extra/clang-tidy/cert/DontModifyStdNamespaceCheck.cpp:80-81
+ auto BadNonTemplateSpecializationDecl =
+
balazske updated this revision to Diff 443609.
balazske marked 2 inline comments as done.
balazske added a comment.
address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129353/new/
https://reviews.llvm.org/D129353
Files:
clang-t
aaron.ballman added inline comments.
Comment at: clang-tools-extra/clang-tidy/cert/DontModifyStdNamespaceCheck.cpp:29
+ continue;
+ArrayRef List1 = Arg.getPackAsArray();
+if (matchesFirstInRange(InnerMatcher, List1.begin(), List1.end(), Finder,
Might
balazske created this revision.
Herald added subscribers: carlosgalvezp, steakhal, martong, gamesh411,
Szelethus, dkrupp, xazax.hun.
Herald added a project: All.
balazske requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Detect t
