[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

sepavloff added a comment. After implementation of D142001 and D143241 this patch is not neded anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129464/new/ https://reviews

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

sepavloff updated this revision to Diff 454822. sepavloff edited the summary of this revision. sepavloff added a comment. Rebase and ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129464/new/ https://reviews.llvm.org/D129464 Files: clang/inc

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

sepavloff added a comment. As specific interaction of FP pragmas and template instantiation was not supported, this patch is actual without additional changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129464/new/ https://reviews.llvm.org/D129

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

sepavloff added a comment. Interaction of pragmas and templates is implemented in https://reviews.llvm.org/D131143. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129464/new/ https://reviews.llvm.org/D129464 ___

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

rjmccall added a comment. This property adheres to a function definition, so it seems to me that an explicit *instantiation* ought to preserve it from the instantiated template definition, but an explicit *specialization* ought to be independent. i.e. #pragma float_control(precise, on, push)

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

sepavloff added inline comments. Comment at: clang/test/CodeGen/pragma-fenv_access.cpp:35 +} + + aaron.ballman wrote: > There are some extra test cases I'd like to see coverage for because there > are some interesting edge cases to consider. > ``` > template >

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

aaron.ballman added a comment. Thank you for looking into this! I happened to run into this same issue with `#pragma float_control` not behaving the way I'd expect. (FWIW, we also ran into an interesting issue where the floating point options were pushed but never popped in the TU were delayed

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

sepavloff created this revision. sepavloff added reviewers: kpn, rjmccall, aaron.ballman. Herald added subscribers: jsji, pengfei. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Previously compilation of a few tests produced incorrect code.