[PATCH] D129507: [OffloadPackager] Add option to extract files from images

jhuber6 added inline comments. Comment at: clang/test/Driver/offload-packager.c:2-3 +// REQUIRES: x86-registered-target +// REQUIRES: nvptx-registered-target +// REQUIRES: amdgpu-registered-target +// UNSUPPORTED: system-windows bader wrote: > Are nvptx and amdgp

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

bader added inline comments. Comment at: clang/test/Driver/offload-packager.c:2-3 +// REQUIRES: x86-registered-target +// REQUIRES: nvptx-registered-target +// REQUIRES: amdgpu-registered-target +// UNSUPPORTED: system-windows Are nvptx and amdgpu target required

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf062954364d: [OffloadPackager] Add option to extract files from images (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129507/new/ htt

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

jhuber6 updated this revision to Diff 454108. jhuber6 added a comment. Updating documentation, cleaning up, and adjusting tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129507/new/ https://reviews.llvm.org/D129507 Files: clang/docs/ClangOf

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/offload-packager.c:26 +// RUN: --image=file=%S/Inputs/dummy-elf.o,kind=hip,triple=amdgcn-amd-amdhsa,arch=gfx90c +// RUN: cd $(dirname "%t") &

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

jhuber6 updated this revision to Diff 454106. jhuber6 added a comment. Using @tra's suggestion to use `cd`. I had to make the test not apply to Windows however, since I had to use `realpath`. But we don't support Windows anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

tra added a comment. In D129507#3730464 , @jhuber6 wrote: > Update, still having problems making the test but I figured I'd just update > now. You could try something like this: https://github.com/llvm/llvm-project/blob/d20e632853ad978e8008747d838d51b51

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

jhuber6 updated this revision to Diff 453456. jhuber6 edited the summary of this revision. jhuber6 added a comment. Update, still having problems making the test but I figured I'd just update now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129507

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

jhuber6 marked 2 inline comments as done. jhuber6 added inline comments. Comment at: clang/test/Driver/offload-packager.c:12-14 +// RUN: clang-offload-packager %t.out \ +// RUN: --image=file=%t-sm_70.o,kind=openmp,triple=nvptx64-nvidia-cuda,arch=sm_70 \ +// RUN: --image=fil

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

tra added inline comments. Comment at: clang/test/Driver/offload-packager.c:12-14 +// RUN: clang-offload-packager %t.out \ +// RUN: --image=file=%t-sm_70.o,kind=openmp,triple=nvptx64-nvidia-cuda,arch=sm_70 \ +// RUN: --image=file=%t-gfx908.o,kind=openmp,triple=amdgcn-amd-am

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

jhuber6 marked 3 inline comments as done. jhuber6 added a comment. Thanks for the comments. Comment at: clang/test/Driver/offload-packager.c:12-14 +// RUN: clang-offload-packager %t.out \ +// RUN: --image=file=%t-sm_70.o,kind=openmp,triple=nvptx64-nvidia-cuda,arch=sm_70 \ +/

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

tra added inline comments. Comment at: clang/test/Driver/offload-packager.c:12-14 +// RUN: clang-offload-packager %t.out \ +// RUN: --image=file=%t-sm_70.o,kind=openmp,triple=nvptx64-nvidia-cuda,arch=sm_70 \ +// RUN: --image=file=%t-gfx908.o,kind=openmp,triple=amdgcn-amd-am