[PATCH] D129864: [Flang] Generate documentation for compiler flags

This revision was automatically updated to reflect the committed changes. Closed by commit rG846439dd97d4: [Flang] Generate documentation for compiler flags (authored by DylanFleming-arm). Changed prior to commit: https://reviews.llvm.org/D129864?vs=446840&id=446889#toc Repository: rG LLVM G

[PATCH] D129864: [Flang] Generate documentation for compiler flags

awarzynski added a comment. LGTM, thanks! (feel free to address my [nit] when merging or ignore altogether) Comment at: flang/docs/CMakeLists.txt:128 + set(CLANG_TABLEGEN_EXE clang-tblgen) + gen_rst_file_from_td(FlangCommandLineReference.rst -gen-opt-docs ../incl

[PATCH] D129864: [Flang] Generate documentation for compiler flags

DylanFleming-arm updated this revision to Diff 446840. DylanFleming-arm added a comment. After pushing to main, this patch cause a buildbot failure as CLANG_TABLEGEN_EXE could not be found. I've updated flang/docs/CMakeLists.txt to set the parameter before making a call to clang_tablegen Repo

[PATCH] D129864: [Flang] Generate documentation for compiler flags

This revision was automatically updated to reflect the committed changes. Closed by commit rG396e944d82f3: [Flang] Generate documentation for compiler flags (authored by DylanFleming-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129864/new/ ht

[PATCH] D129864: [Flang] Generate documentation for compiler flags

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. The change in ClangOptionDocEmitter.cpp is required for Flang as it heavily relies on these "include" flags defined in Options.td

[PATCH] D129864: [Flang] Generate documentation for compiler flags

DylanFleming-arm updated this revision to Diff 445872. DylanFleming-arm added a comment. Edited summary to be more clear. I've also changed the format of the if(!included) as you suggested (and did the same for the call to isGroupIncluded) I also added the assert you asked for, and then since t

[PATCH] D129864: [Flang] Generate documentation for compiler flags

awarzynski added a comment. Makes sense, thanks for working on this! Some minor comments below and inline. From your summary: > This is done by using clang tablegen What do you mean by "clang tablegen"? Is it Clang's clang_tablegen

[PATCH] D129864: [Flang] Generate documentation for compiler flags

DylanFleming-arm created this revision. Herald added subscribers: arphaman, mgorny. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. DylanFleming-arm requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This patch