[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman added a comment. In D129881#3674159 , @augusto2112 wrote: > Actually, never mind, I think I can fix the tests. Thank you for the fix, and sorry for the trouble! In D129881#3674157 , @augusto2112

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

augusto2112 added a comment. Actually, never mind, I think I can fix the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ https://reviews.llvm.org/D129881 ___ cfe-commits mailing list cfe

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

augusto2112 added a comment. Hi @aaron.ballman, it looks like this broke 2 tests in the lldb test suite (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45560/). Can we revert this to keep CI green? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

This revision was automatically updated to reflect the committed changes. Closed by commit rG7068aa98412a: Strengthen -Wint-conversion to default to an error (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ http

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

efriedma accepted this revision as: efriedma. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ https://reviews.llvm.org/D129881 ___ cfe-commits mailing l

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ https://reviews.llvm.org/D129881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8483 +if ((SemaRef.getLangOpts().CPlusPlus && Trap.hasErrorOccurred()) || +Res.isInvalid()) return ExprError(); aaron.ballman wrote: > efriedma wrote: > > I'd prefe

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman updated this revision to Diff 445086. aaron.ballman added a comment. Removed the SFINAEFailure and trap changes, added a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ https://reviews.llvm.org/D129881 Files: clang-tools-extra/test/clang-tidy/che

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8483 +if ((SemaRef.getLangOpts().CPlusPlus && Trap.hasErrorOccurred()) || +Res.isInvalid()) return ExprError(); efriedma wrote: > I'd prefer not to introduce unnece

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

efriedma added a comment. Given this is an on-by-default warning already, I don't expect changing it to an error by default to have much impact in practice. Changing it fine. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8483 +if ((SemaRef.getLangOpts().CPlusPlus && Trap.has

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

erichkeane added a comment. This seems like a good idea despite the breaking change. I dont see anything in the code to be concerned about, but I'm hoping others will comment as to whether this is completely acceptable. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8482 Ex

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman created this revision. aaron.ballman added reviewers: efriedma, jyknight, erichkeane, clang-language-wg. Herald added subscribers: steakhal, Enna1, kosarev, arphaman, jvesely. Herald added a project: All. aaron.ballman requested review of this revision. Herald added projects: clang,