[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG258d7b86eeab: [clang-format] Handle constructor invocations after new operator in C# correct (authored by eoanermine, committed by owenpan). Changed

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

owenpan added a comment. In D129926#3769542 , @curdeius wrote: > @eoanermine, please provide your name and email address for the commit > message. We can use "Danil Sidoruk " as I did in d8d331bc9710

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

aaron.ballman added a comment. In D129926#3788866 , @MyDeveloperDay wrote: > @eoanermine ping... we need your name/email before we can commit. > > (@curdeius, @owenpan, @HazardyKnusperkeks ) we need to have a policy for > this, that if we don't get the

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

MyDeveloperDay added a subscriber: aaron.ballman. MyDeveloperDay added a comment. @eoanermine ping... we need your name/email before we can commit. (@curdeius, @owenpan, @HazardyKnusperkeks ) we need to have a policy for this, that if we don't get the name for a commit we are happy to land, tha

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

curdeius added a comment. @eoanermine, please provide your name and email address for the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129926/new/ https://reviews.llvm.org/D129926 ___ cf

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

eoanermine updated this revision to Diff 452513. eoanermine added a comment. - Add examples to comments - Reformat comments right Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129926/new/ https://reviews.llvm.org/D129926 Files: clang/lib/Format/

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

eoanermine added a comment. In D129926#3705342 , @MyDeveloperDay wrote: > Can we land this for you? Yes Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2869-2870 + // Handle array initialization syntax if (FormatTok-

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Can we land this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129926/new/ https://reviews.llvm.org/D129926 ___ cfe-commits

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

curdeius accepted this revision. curdeius added a comment. LGTM. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2864 do { + // Handle constructor invocation + if (FormatTok->is(tok::l_paren)) Nit: comments should be full phrases, ending wit

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

eoanermine created this revision. eoanermine added reviewers: owenpan, HazardyKnusperkeks, MyDeveloperDay. eoanermine added projects: clang, clang-format. Herald added a project: All. eoanermine requested review of this revision. Herald added a subscriber: cfe-commits. - Handle constructor invocat