[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG174e954e370e: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions` (authored by awarzynski). Changed prior to commit:

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

awarzynski updated this revision to Diff 447250. awarzynski added a comment. Change from CamelCase to camelCase in Flang.h so that the function names adhere to LLVM's coding style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130078/new/

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

awarzynski added a comment. In D130078#3673288 , @MaskRay wrote: > In D130078#3669072 , @awarzynski > wrote: > >> In D130078#3667188 , @MaskRay >> wrote: >> >>>

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

MaskRay added a comment. In D130078#3669072 , @awarzynski wrote: > In D130078#3667188 , @MaskRay wrote: > >> `forwardOptions` will be better if you are renaming it anyway. > > I'd rather create a separate patch

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

awarzynski added a comment. In D130078#3667188 , @MaskRay wrote: > `forwardOptions` will be better if you are renaming it anyway. I'd rather create a separate patch and update all other methods to follow LLVM's style. Any idea why the style is not

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

MaskRay added a comment. `forwardOptions` will be better if you are renaming it anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130078/new/ https://reviews.llvm.org/D130078 ___ cfe-commits mailing

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

tarunprabhu accepted this revision. tarunprabhu added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130078/new/ https://reviews.llvm.org/D130078

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

awarzynski created this revision. awarzynski added a reviewer: tarunprabhu. Herald added a reviewer: sscalpone. Herald added a project: All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The updated name better