[PATCH] D130259: [clangd] fix crash and handle implicit conversions in inlay hints for forwarding functions

upsj abandoned this revision. upsj added a comment. Superseded by https://reviews.llvm.org/D130260 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130259/new/ https://reviews.llvm.org/D130259 ___ cfe-commi

[PATCH] D130259: [clangd] fix crash and handle implicit conversions in inlay hints for forwarding functions

kadircet added a comment. In D130259#3671022 , @nridge wrote: > Which bug/issue is this? https://github.com/llvm/llvm-project/issues/56620 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130259/new/ https:/

[PATCH] D130259: [clangd] fix crash and handle implicit conversions in inlay hints for forwarding functions

nridge added a comment. In D130259#3671009 , @kadircet wrote: > sorry for not mentioning in the bug that i was also working on a patch, Which bug/issue is this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D130259: [clangd] fix crash and handle implicit conversions in inlay hints for forwarding functions

kadircet added a comment. sorry for not mentioning in the bug that i was also working on a patch, D130260 seems to be a little bit more contained and focused on making the check not crash (as we're getting close to release cut). WDYT about landing it now, an

[PATCH] D130259: [clangd] fix crash and handle implicit conversions in inlay hints for forwarding functions

upsj added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:721 +} + )cpp" /*, ExpectedHint{"s: ", "param1"}, ExpectedHint{"x: ", "param2"}*/); +} I'm not sure whether we should detect this case, since it would be nice to h

[PATCH] D130259: [clangd] fix crash and handle implicit conversions in inlay hints for forwarding functions

upsj created this revision. upsj added reviewers: nridge, sammccall, kadircet. upsj added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. upsj requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.