[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG4dd71b3cb947: [clang] Give priority to Class context while parsing declarations (authored by furkanusta, committed by kadircet). Changed prior to commit: https://reviews.llvm.org/D130363?vs=451604&id=45

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

furkanusta marked an inline comment as not done. furkanusta added a comment. That would be great, thanks Comment at: clang/test/CodeCompletion/overrides.cpp:41 +// Runs completion at empty line on line 13. +// RUN: %clang_cc1 -fsyntax-only -code-completion-patterns -code-compl

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! let me know if i should land this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130363/new/ https://reviews.llvm.org/

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

furkanusta updated this revision to Diff 451604. furkanusta added a comment. - [clangd] D130363 (CodeCompletion/overrides.cpp) Move tests to bottom Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130363/new/ https:

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

kadircet added a comment. > Is my invocation correct or is this case handled by clangd and not clang? yeah your invocation is correct. this is because clang's printer does a prefix based filtering (while clangd does a fuzzy match) https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/Co

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

furkanusta added a comment. I've added a test case but I have a question. This is regardless of the current issue (i.e. no function context, clang++14 with no patches) struct X { virtual void foo(); }; struct Y : public X { over }; I am trying to complete override in class Y here, b

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

furkanusta updated this revision to Diff 448694. furkanusta added a comment. - [clang] Add test case for D130363 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130363/new/ https://reviews.llvm.org/D130363 Files:

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

kadircet added a comment. Can you also add a test, preferably in clang/test/CodeCompletion/overrides.cpp ? Comment at: clang/lib/Parse/ParseDecl.cpp:3269 - if (getCurScope()->getFnParent() || getCurScope()->getBlockParent()) -CCC = Sema::PCC_LocalDeclarationSpeci

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

furkanusta created this revision. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. furkanusta requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Fixes: https://github.com/clangd/clangd/issues/290 Repo