[PATCH] D130421: [Clang] De-deprecate volatile compound operations

2022-07-24 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. @aaron.ballman Thanks a lot for the review. I made a separate nfc commit to address the missing revision numbers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130421/new/ https://reviews.llvm.org/D130421 ___

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

2022-07-24 Thread Corentin Jabot via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ba128f7c8c2: [Clang] De-deprecate volatile compound operations (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D130421?

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

2022-07-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/ReleaseNotes.rst:519-523 - Implemented `P2290 Delimited escape sequences `_. This feature is availab

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

2022-07-23 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. @shafik Thanks for the review! Comment at: clang/docs/ReleaseNotes.rst:523 This feature is available as an extension in all C and C++ language modes. +- Implemented `P2327 De-deprecating volatile compound operations `_

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

2022-07-23 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 447109. cor3ntin added a comment. Fix paper number in release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130421/new/ https://reviews.llvm.org/D130421 Files: clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

2022-07-23 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. LGTM but I will let Aaron accept it. Comment at: clang/docs/ReleaseNotes.rst:523 This feature is available as an extension in all C and C++ language modes. +- Implemented `P2327 De-deprecating volatile compound operations `

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

2022-07-23 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. @aaron.ballman I think getting that in 15 would avoid some churn, WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130421/new/ https://reviews.llvm.org/D130421 ___ cfe-commit

[PATCH] D130421: [Clang] De-deprecate volatile compound operations

2022-07-23 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As per P2327R1, | =, &= and ^= are no longer deprecated in all languages mode. | Repository: rG LLVM Github Monorepo