alexfh added a comment.
Still looks good.
http://reviews.llvm.org/D13052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
angelgarcia updated this revision to Diff 35630.
angelgarcia added a comment.
Done!
http://reviews.llvm.org/D13052
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
clang-tidy/modernize/LoopConvertCheck.h
clang-tidy/modernize/LoopConvertUtils.cpp
clang-tidy/modernize/LoopConvertUtils.h
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a comment. Thank you!
Comment at: test/clang-tidy/modernize-loop-convert-uppercase.cpp:48
@@ +47,3 @@
+ // CHECK-FIXES: for (auto & NUMS_ELEM : NUMS)
+ // CH
angelgarcia updated this revision to Diff 35608.
angelgarcia added a comment.
> No need to check the length. `endswith` handles this itself.
I am checking that it is strictly greater than one, because we don't want an
empty identifier after removing the "s".
http://reviews.llvm.org/D13052
Fi
alexfh added a comment.
A few minor comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.h:68
@@ -67,2 +67,3 @@
Confidence::Level MinConfidence;
+ VariableNamer::NamingStyle NamingStyle;
};
The variable can be const, the one above as well.
=
angelgarcia updated this revision to Diff 35380.
angelgarcia marked 10 inline comments as done.
angelgarcia added a comment.
Use CamelCase on the existing tests and add a test for every other naming
convention.
http://reviews.llvm.org/D13052
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
alexfh added inline comments.
Comment at: clang-tidy/modernize/LoopConvertUtils.cpp:815
@@ -815,3 +814,3 @@
std::string IteratorName;
std::string ContainerName;
if (TheContainer)
This can be a StringRef to avoid some copies.
Comment at:
angelgarcia updated this revision to Diff 35362.
angelgarcia added a comment.
Remove related FIXME.
http://reviews.llvm.org/D13052
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
clang-tidy/modernize/LoopConvertCheck.h
clang-tidy/modernize/LoopConvertUtils.cpp
clang-tidy/modernize/Loop
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: klimek, cfe-commits.
Add an option to specify wich style must be followed when choosing the new
index name.
http://reviews.llvm.org/D13052
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
