[PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

2017-04-13 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno closed this revision. bruno added a comment. Done way back in r248932 Repository: rL LLVM https://reviews.llvm.org/D13117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

2015-09-24 Thread Duncan P. N. Exon Smith via cfe-commits
dexonsmith added a comment. Sorry for the review fragmentation, but I just noticed there's no test for the new warning. Can you add one? After that, LGTM. Repository: rL LLVM http://reviews.llvm.org/D13117 ___ cfe-commits mailing list cfe-commi

Re: [PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

2015-09-24 Thread Duncan P. N. Exon Smith via cfe-commits
Sorry for the review fragmentation, but I just noticed there's no test for the new warning. Can you add one? After that, LGTM. > On 2015-Sep-24, at 11:57, Bruno Cardoso Lopes wrote: > > bruno updated this revision to Diff 35664. > bruno added a comment. > > Added test per Duncan's comment. >

Re: [PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

2015-09-24 Thread Bruno Cardoso Lopes via cfe-commits
bruno updated this revision to Diff 35664. bruno added a comment. Added test per Duncan's comment. Repository: rL LLVM http://reviews.llvm.org/D13117 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/Tools.cpp test/Driver/darwin-ld.c Index: test/Driver/darwin-ld.c ===

Re: [PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

2015-09-23 Thread Duncan P. N. Exon Smith via cfe-commits
The code LGTM, but there ought to be a way to add a LIT test for this. Looking for -object_path_lto, I found this: -- // RUN: %clang -target x86_64-apple-darwin10 -### %s \ // RUN: -mlinker-version=117 -flto 2> %t.log // RUN: cat %t.log // RUN: FileCheck -check-prefix=LINK_OBJECT_LTO_PATH %s < %

Re: [PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

2015-09-23 Thread Duncan P. N. Exon Smith via cfe-commits
dexonsmith added a subscriber: dexonsmith. dexonsmith added a comment. The code LGTM, but there ought to be a way to add a LIT test for this. Looking for -object_path_lto, I found this: --- // RUN: %clang -target x86_64-apple-darwin10 -### %s \ // RUN: -

[PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

2015-09-23 Thread Bruno Cardoso Lopes via cfe-commits
bruno created this revision. bruno added a reviewer: dexonsmith. bruno added subscribers: cfe-commits, kledzik, bob.wilson. bruno set the repository for this revision to rL LLVM. Usually, when using LTO with a clang installation newer than the system one, there's a libLTO.dylib version mismatch a