[PATCH] D131202: [Clang] Fix capture of values initialized by bitfields

2022-08-10 Thread Alexander Yermolovich via Phabricator via cfe-commits
ayermolo added a comment. Thanks for reverting this. Previous commit broke build of projects using fmt library. https://github.com/fmtlib/fmt/blame/master/include/fmt/format.h fmt/fmt/include/fmt/format.h:1904:9: error: cannot capture a bit-field by reference if (sign) *it++ = detail::s

[PATCH] D131202: [Clang] Fix capture of values initialized by bitfields

2022-08-04 Thread Corentin Jabot via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1a71b7dc97b: [Clang] Fix capture of values initialized by bitfiel

[PATCH] D131202: [Clang] Fix capture of values initialized by bitfields

2022-08-04 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 450138. cor3ntin added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Better approach: revert the whole thing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131202/new/ htt

[PATCH] D131202: [Clang] Fix capture of values initialized by bitfields

2022-08-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/lambda-expressions.cpp:680 + auto l = [&]() { + a; // expected-error{{cannot capture a bit-field by reference}} + b; This still should be accepted -- `a` is an `const int &`

[PATCH] D131202: [Clang] Fix capture of values initialized by bitfields

2022-08-04 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a regression introduced in 127bf44 Rep