[PATCH] D131388: [docs] Add "Standard C++ Modules"

ChuanqiXu updated this revision to Diff 455462. ChuanqiXu retitled this revision from "[docs] Add "C++20 Modules"" to "[docs] Add "Standard C++ Modules"". ChuanqiXu edited the summary of this revision. ChuanqiXu added a comment. Replace `C++20 Modules` with `Standard C++ Modules` since @ruoso poi

[PATCH] D131388: [docs] Add "Standard C++ Modules"

h-vetinari added a comment. In D131388#3748062 , @ChuanqiXu wrote: > Replace `C++20 Modules` with `Standard C++ Modules` since @ruoso pointed out > that `Modules` is not specific to certain versions of C++ (for example, > Modules may get some big change

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ruoso added a comment. I just noticed that the document was implying that Header Units were separate from the Standard C++ Modules, but they are an integral part of the language in the specification of modules. The contrast that we do is between "Named Modules" and "Header Units". I did some ed

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ChuanqiXu added a comment. In D131388#3748769 , @ruoso wrote: > I just noticed that the document was implying that Header Units were separate > from the Standard C++ Modules, but they are an integral part of the language > in the specification of module

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ChuanqiXu updated this revision to Diff 455802. ChuanqiXu marked 5 inline comments as done. ChuanqiXu added a comment. Address comments: - Change the file name to `StandardCPlusPlusModules` - Combine header units with modules more tightly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ChuanqiXu added a comment. In D131388#3748769 , @ruoso wrote: > I just noticed that the document was implying that Header Units were separate > from the Standard C++ Modules, but they are an integral part of the language > in the specification of module

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ruoso accepted this revision. ruoso added a comment. Thanks for taking my last minute suggestions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D131388: [docs] Add "Standard C++ Modules"

bbrown105 added a comment. Nice writeup! I appreciate the work that went into this. Comment at: clang/docs/StandardCPlusPlusModules.rst:27 + +standard C++ Named modules +== Just matching the capitalization of the other sections and subse

[PATCH] D131388: [docs] Add "Standard C++ Modules"

aaronmondal added a comment. @ChuanqiXu Thanks a lot for this! We are currently implementing this module logic in the Bazel ruleset rules_ll . This page helps clarify the differences between clang modules and C++ modules a lot. If I knew about this earlier we'

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ChuanqiXu updated this revision to Diff 456244. ChuanqiXu marked 5 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388 Files: clang/docs/StandardCPlusPlusModules.rst clang/d

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ChuanqiXu updated this revision to Diff 456254. ChuanqiXu added a comment. Add contents for "When precompiling a module in one directory and then moving a header included in the global module fragment from the source file, things will break." CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ChuanqiXu added a comment. In D131388#3753522 , @aaronmondal wrote: > @ChuanqiXu Thanks a lot for this! > > We are currently implementing this module logic in the Bazel ruleset rules_ll > . > This page helps clarify th

[PATCH] D131388: [docs] Add "Standard C++ Modules"

aaronmondal accepted this revision. aaronmondal added a comment. Thanks for addressing my comment. I think I overlooked the part about `-fmodules-embed-all-files` 😅 I'm fine with this revision 😊 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388

[PATCH] D131388: [docs] Add "Standard C++ Modules"

aaronmondal requested changes to this revision. aaronmondal added a comment. This revision now requires changes to proceed. I just noticed that there probably needs to be one change. The doc sometimes describes `-fprebuilt-module-interface`, which is not a valid option. I think the occurrences w

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ChuanqiXu updated this revision to Diff 456844. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388 Files: clang/docs/StandardCPlusPlusModules.rst clang/docs/index.rst Index: clang/docs/index.rst =

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ChuanqiXu added a comment. In D131388#3758898 , @aaronmondal wrote: > I just noticed that there probably needs to be one change. The doc sometimes > describes `-fprebuilt-module-interface`, which is not a valid option. I think > the occurrences were me

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ChuanqiXu added a comment. @bbrown105 I am going to land this today. it looks like you're not objecting it and we don't have the time to wait for your formal approval... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ChuanqiXu accepted this revision. ChuanqiXu added a comment. I'm going to land this. Thanks for everyone who reviewed this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388 ___ cfe-commits mailing lis

[PATCH] D131388: [docs] Add "Standard C++ Modules"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb1d5af81249d: [docs] Add "Standard C++ Modules" (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES S