nickdesaulniers added a comment.
https://llvm-compile-time-tracker.com/compare.php?from=0299ebc1bdc9fca176ebcacd590c90dc77a47551=333771f3558c81390a0e5d715ad8d1e419050b66=cycles
should be the link, once it gets picked up.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
This revision was automatically updated to reflect the committed changes.
Closed by commit rG333771f3558c: [Sema] Avoid isNullPointerConstant invocation
(authored by justinstitt, committed by nickdesaulniers).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
Awesome! This makes a measurable improvement in my Linux kernel build times!
Thanks for the patch, and thanks @rtrieu for suggestions that will improve C++
code compilation times as well.
I'll commit this for you since
justinstitt updated this revision to Diff 451955.
justinstitt added a comment.
move return to new line, as per clang-format.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131532/new/
https://reviews.llvm.org/D131532
Files:
justinstitt updated this revision to Diff 451902.
justinstitt edited the summary of this revision.
justinstitt added a comment.
add more descriptive names, add more detail to revision summary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
rtrieu accepted this revision.
rtrieu added a comment.
This revision is now accepted and ready to land.
I think this is a reasonable step for improving compile times. I put some
suggestions for more descriptive names below (he said, after suggesting those
names in the first place).
The
justinstitt updated this revision to Diff 451687.
justinstitt added a comment.
use @rtrieu 's suggestion regarding not invoking isNullPointerConstant as
opposed to checking for C++ lang opt.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131532/new/
https://reviews.llvm.org/D131532
