listout marked an inline comment as done.
listout added a comment.
@barannikov88 made some changes. What do you think?
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:49
+ std::string EnvName = TargetTriple.isMusl() ? "musl" : "gnu";
+
barannikov88 wrote:
listout updated this revision to Diff 451757.
listout added a comment.
Using `getEnvironmentTypeName()` instead of `isMusl()`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131563/new/
https://reviews.llvm.org/D131563
Files:
clang/lib/Driver/ToolChains/Linux.cpp
Index: clang/lib/Dri
barannikov88 added a comment.
The diff seems to be restricted to few lines. It should include the full
context.
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:49
+ std::string EnvName = TargetTriple.isMusl() ? "musl" : "gnu";
+
* `!isMusl()` does not mea
listout updated this revision to Diff 451572.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131563/new/
https://reviews.llvm.org/D131563
Files:
clang/lib/Driver/ToolChains/Linux.cpp
Index: clang/lib/Driver/ToolChains/Linux.cpp
=
listout updated this revision to Diff 451459.
listout added a comment.
Fix missing '+'
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131563/new/
https://reviews.llvm.org/D131563
Files:
clang/lib/Driver/ToolChains/Linux.cpp
Index: clang/lib/Driver/ToolChains/Linux.cpp
==
listout updated this revision to Diff 451452.
listout added a comment.
Herald added subscribers: pcwang-thead, luke957, s.egerton, simoncook.
Less drastic changes and rebased with main
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131563/new/
https://reviews.llvm.org/D131563
Files:
c
