[PATCH] D131569: [clangd] Allow updates to be canceled after compile flags retrieval

2022-08-11 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:898 +if (isCancelled()) { + log("ASTWorker skipping update {0} for file {1}", Inputs.Version, + FileName); I'd add something like "due to cancellation". I know yo

[PATCH] D131569: [clangd] Allow updates to be canceled after compile flags retrieval

2022-08-10 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. Could you please add a test with a compilation database that models the blocking behavior, attempts cancellation and ensures no diagnostics are produced? I also suggest adding a callback similar to `Callbacks.onFailedAST`, which could be used for testing this beha

[PATCH] D131569: [clangd] Allow updates to be canceled after compile flags retrieval

2022-08-10 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, arphaman, javed.absar. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra.