adamcz added inline comments.
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:898
+if (isCancelled()) {
+ log("ASTWorker skipping update {0} for file {1}", Inputs.Version,
+ FileName);
I'd add something like "due to cancellation". I know yo
ilya-biryukov added a comment.
Could you please add a test with a compilation database that models the
blocking behavior, attempts cancellation and ensures no diagnostics are
produced?
I also suggest adding a callback similar to `Callbacks.onFailedAST`, which
could be used for testing this beha
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: usaxena95, arphaman, javed.absar.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang-tools-extra.