[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

awarzynski accepted this revision. awarzynski added a comment. LGTM, thanks for the fix! You may want to update to title to better reflect the contents (e.g. “Add help text for -fsyntax-only”). While the fact that it fixes https://github.com/llvm/llvm-project/issues/57033 motivated this

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof added a comment. Could someone land this patch please? Alexander Malkov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 ___ cfe-commits mailing list

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof added a comment. I can't merge the changes(( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof updated this revision to Diff 452487. alexiprof added a comment. replase text hint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

MaskRay added a comment. To be clear, some issues should be addressed before someone lands this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 ___

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof added a comment. I do not have commit access, i do not have merge :-( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 ___ cfe-commits mailing list

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

MaskRay added a comment. > https://github.com/llvm/llvm-project/issues/57033 Use `Fix https://github.com/llvm/llvm-project/issues/57033` or `Fixes https://github.com/llvm/llvm-project/issues/57033` or (I usually prefer this for non-bugs but still some issues worth addressing) `Close ...`, then

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

MaskRay accepted this revision. MaskRay added a comment. > Subject: [clang,flang] Add missing options fsyntax-only in help Prefer `-fsyntax-only` to `fsyntax-only` since the former is what a user writes. > this pull request contains a fix for the problem with displaying options > -fsyntax_only

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof updated this revision to Diff 452431. alexiprof added a comment. remove Unrelated change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof updated this revision to Diff 452429. alexiprof added a comment. this pull request contains a fix for the problem with displaying options -fsyntax_only in clang and fland-new in help https://github.com/llvm/llvm-project/issues/57033 Before: $ clang -help | grep syntax

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof added inline comments. Comment at: clang/include/clang/Driver/Options.td:2798-2799 def fsyntax_only : Flag<["-"], "fsyntax-only">, - Flags<[NoXarchOption,CoreOption,CC1Option,FC1Option]>, Group; + Flags<[NoXarchOption,CoreOption,CC1Option,FC1Option,FlangOption]>,

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof updated this revision to Diff 452405. alexiprof added a comment. Set new text hint for option fsyntax-only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 Files:

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof added a comment. In D131808#3720910 , @awarzynski wrote: > Thanks, mostly makes sense! https://github.com/llvm/llvm-project/issues/57033 > mentions `-O{n}` as well :) Could you fix that too? More comments inline. > > CI is still failing :(

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof updated this revision to Diff 452393. alexiprof added a comment. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

awarzynski added a comment. Thanks, mostly makes sense! https://github.com/llvm/llvm-project/issues/57033 mentions `-O{n}` as well :) Could you fix that too? More comments inline. CI is still failing :( Are you able to re-produce that? (I'm traveling atm, so can't check).

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

awarzynski added a comment. This is primarily a Clang change, so added some Clang reviewers. I will review shortly - thanks for taking this on! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof updated this revision to Diff 452383. alexiprof added a comment. Fix revision Differential Revision: https://reviews.llvm.org/D131808 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 Files:

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof updated this revision to Diff 452382. alexiprof added a comment. This is commit fix flang unit tests in using help command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 Files:

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

peixin added a comment. The CI failed since the test cases in flang driver have new output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 ___ cfe-commits

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

vzakhari accepted this revision. vzakhari added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof created this revision. Herald added a reviewer: sscalpone. Herald added a project: All. alexiprof requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. this pull request contains a fix for the problem with displaying options