[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank marked an inline comment as done. nicovank added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Ping. @njames93 If you have a minute, could you please take a second look at this? Let me know what's needed to get this change landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Thank you for the feedback! In D131939#3822766 , @njames93 wrote: > I have a feeling the default should be to only warm in loops otherwise this > could get noisy. Agreed, the less noisy version was already the default,

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank updated this revision to Diff 464362. nicovank added a comment. Rename OnlyWarnInLoops to WarnOutsideLoops, cover missed cxxForRangeStmt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 Files:

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

njames93 added a comment. I have a feeling the default should be to only warm in loops otherwise this could get noisy. Though setting it as the default you'd likely want to change the name to something along the lines of WarmOutsideLoops. Comment at:

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a reviewer: JonasToth. nicovank added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Ping. F24615059: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank updated this revision to Diff 461592. nicovank added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.txt

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Mid-CppCon ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. In D131939#3755399 , @Eugene.Zelenko wrote: > I got notification. Thank you. I got an email for this message but not my own updates, which usually also CC me 路. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

Eugene.Zelenko added a comment. I got notification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Ping. I feel like Phabricator is not sending notifications for this patch like it usually does (I'm not getting any emails). I'll create a new, identical patch tomorrow if there's still no activity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a reviewer: alexfh. nicovank added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D131939 ___ cfe-commits mailing list

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank created this revision. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Herald added a project: All. nicovank edited the summary of this revision. nicovank edited the summary of this revision. nicovank updated this revision to Diff 452886. nicovank updated this revision to Diff