This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG10194a51a9d3: [HLSL] Restrict to supported targets (authored
by beanz).
Changed prior to commit:
Anastasia accepted this revision.
Anastasia added a comment.
This makes sense. I believe the same applies to some other languages i.e.
OpenCL, as the way clang evolved currently not all targets are compatible with
all languages. In the future we might want to generalize this diagnostics to
use
jcranmer-intel accepted this revision.
jcranmer-intel added a comment.
This revision is now accepted and ready to land.
I don't necessarily know clang-specific code to have that valuable an opinion
here, but I don't see anything wrong.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
beanz updated this revision to Diff 456746.
beanz added a comment.
Adding the FIXME suggested by @aaron.ballman. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132056/new/
https://reviews.llvm.org/D132056
Files:
aaron.ballman added reviewers: ABataev, Anastasia.
aaron.ballman added a comment.
I don't have particular concerns FWIW, but I'm not certain if others have
opinions so I'm holding off on accepting for a bit.
Comment at: clang/test/Driver/hlsl-lang-targets.hlsl:14
+
+// Maybe
beanz created this revision.
beanz added reviewers: aaron.ballman, bogner, python3kgae, pow2clk,
jcranmer-intel.
Herald added subscribers: Anastasia, JDevlieghere.
Herald added a project: All.
beanz requested review of this revision.
Herald added a project: clang.
Someday we would like to
