This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG772fc63f5bb5: [IncludeCleaner] Handle more C++ constructs
(authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kadircet updated this revision to Diff 470393.
kadircet marked 4 inline comments as done.
kadircet added a comment.
- Rebase
- Add FIXMEs
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132110/new/
https://reviews.llvm.org/D132110
Files:
clang-too
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:66
+ bool VisitOverloadExpr(OverloadExpr *E) {
+// Mark all candidates as used when overload is n
kadircet added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:55
+ bool VisitMemberExpr(MemberExpr *E) {
+auto *MD = E->getMemberDecl();
+report(E->getMemberLoc(), MD);
sammccall wrote:
> sammccall wrote:
> > nit: inline?
kadircet updated this revision to Diff 453638.
kadircet marked 5 inline comments as done.
kadircet added a comment.
- Adress comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132110/new/
https://reviews.llvm.org/D132110
Files:
clang-tools-e
sammccall added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:55
+ bool VisitMemberExpr(MemberExpr *E) {
+auto *MD = E->getMemberDecl();
+report(E->getMemberLoc(), MD);
nit: inline?
Comment at: clang-to
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, ilya-biryukov.
Herald added a project: clang-tools-extra.
This brings IncludeCleaner's reference discovery from AST
