[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rG5777c05d1609: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132136

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, this wasn't quite what I had in mind, but I can see how my suggestion was going to be far too tricky to try to implement as a lit test. Thanks for adding the unit test coverage! CHANGES SINCE LAST ACTION https://revie

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

tbaeder updated this revision to Diff 457838. tbaeder added a comment. Add a unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132136/new/ https://reviews.llvm.org/D132136 Files: clang/lib/AST/ExprConstant.cpp clang/test/AST/Interp/literals.cpp clang/unittests/AST/Evaluate

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

tbaeder added a comment. In D132136#3766958 , @aaron.ballman wrote: > On the one hand, I'm not comfortable landing this without adequate testing, > especially because you want to build more stuff on top of it. I think we need > to make sure the foundat

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

aaron.ballman added a comment. In D132136#3766140 , @tbaeder wrote: > @aaron.ballman Can you comment on my last question? I'd like to land this > patch since the others depend on it. Sorry for the delay! In D132136#3760738

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

tbaeder added a comment. @aaron.ballman Can you comment on my last question? I'd like to land this patch since the others depend on it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132136/new/ https://reviews.llvm.org/D132136 ___ cfe-commit

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

tbaeder added a comment. In D132136#3755724 , @aaron.ballman wrote: > In D132136#3753290 , @tbaeder wrote: > >> In D132136#3751702 , @erichkeane >> wrote: >> >>> Would b

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

aaron.ballman added a comment. In D132136#3753290 , @tbaeder wrote: > In D132136#3751702 , @erichkeane > wrote: > >> Would be great if we had a better test here... is there anything we can do >> to validate this

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

tbaeder added a comment. In D132136#3751702 , @erichkeane wrote: > Would be great if we had a better test here... is there anything we can do to > validate this is happening other than checking for that one note? `EvaluateAsRValue` is called from `Expr

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

aaron.ballman added a comment. In D132136#3751702 , @erichkeane wrote: > Would be great if we had a better test here... is there anything we can do to > validate this is happening other than checking for that one note? +1 to this request, but the chang

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Would be great if we had a better test here... is there anything we can do to validate this is happening other than checking for that one note? CHANGES SINCE LAST ACTION https://rev

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

tbaeder added a comment. Can I get another opinion on this before the weekend? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132136/new/ https://reviews.llvm.org/D132136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

tbaeder updated this revision to Diff 455792. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132136/new/ https://reviews.llvm.org/D132136 Files: clang/lib/AST/ExprConstant.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp/literals.cpp ==

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:14938 + + if (E->getType().isNull()) +return false; shafik wrote: > Curious why these two checks don't go w/ the `::Evaluate(Result, Info, E)` > below. No real reason I think, it's ju

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:14938 + + if (E->getType().isNull()) +return false; Curious why these two checks don't go w/ the `::Evaluate(Result, Info, E)` below. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

tbaeder created this revision. tbaeder added reviewers: erichkeane, aaron.ballman, shafik, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extra bonus patch. The EvaluateAsRValue() document