[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn_b{32|64}

2022-08-18 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 453681. yaxunl added a comment. revised by Brian's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132140/new/ https://reviews.llvm.org/D132140 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/lib/CodeGen/CGBuiltin.cpp clang/te

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn_b{32|64}

2022-08-18 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D132140#3732262 , @b-sumner wrote: > Following existing naming, it might make sense to rename "rtn_b32" --> "rtn" > and "rtn_b64" --> "rtnl". will modify. thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132140/

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn_b{32|64}

2022-08-18 Thread Brian Sumner via Phabricator via cfe-commits
b-sumner added a comment. Following existing naming, it might make sense to rename "rtn_b32" --> "rtn" and "rtn_b64" --> "rtnl". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132140/new/ https://reviews.llvm.org/D132140 ___ cfe-commits maili

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn_b{32|64}

2022-08-18 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: b-sumner, arsenm, foad, kzhuravl, bcahoon. Herald added subscribers: kosarev, kerbowa, t-tye, tpr, dstuttard, jvesely. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.